Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] No histogram brushing on number histograms #79570

Closed

Conversation

wylieconlon
Copy link
Contributor

Only date histograms are brushable now, which fixes the unexpected behavior of number histograms during testing of 7.10.

Fixes #79260
Replaces #79435

Checklist

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.10.0 v7.11.0 labels Oct 5, 2020
@wylieconlon wylieconlon requested review from dej611, flash1293, mbondyra and a team October 5, 2020 21:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

onBrushEnd={({ x }) => {
const extraSettings: Partial<SettingsSpec> = isTimeViz
? {
onBrushEnd: ({ x }) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is entirely copy+pasted and moved. The diff shows it being a larger change than it was.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
lens 1.0MB 1.0MB +95.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon
Copy link
Contributor Author

Closing because we've chosen to enable the feature instead of disabling

@wylieconlon wylieconlon closed this Oct 6, 2020
@wylieconlon wylieconlon deleted the lens/no-histogram-brushing branch October 6, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Number histogram brushing doesn't add filter
4 participants