Remove APM stacktrace snapshots #79543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results. Move the test files out of the __test__ directory and rename the directory to __fixtures__.
smith
added
v8.0.0
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Oct 6, 2020
smith
added a commit
to smith/kibana
that referenced
this pull request
Oct 6, 2020
* Remove APM stacktrace snapshots These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results. Move the test files out of the __test__ directory and rename the directory to __fixtures__. # Conflicts: # x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap
smith
added a commit
that referenced
this pull request
Oct 7, 2020
These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results. Move the test files out of the __test__ directory and rename the directory to __fixtures__. # Conflicts: # x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap * Snapshot update
jportner
pushed a commit
to jportner/kibana
that referenced
this pull request
Dec 14, 2020
* Remove APM stacktrace snapshots These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results. Move the test files out of the __test__ directory and rename the directory to __fixtures__.
|
FYSA, I had to backport this to 7.10 to support a related dependency upgrade backport: #85369 No action needed, just wanted to let you know 😄 Edit: looking at the labels, it seems like it was intended to backport this to 7.10 but it just missed feature freeze and only made it into 7.11. I'll add the 7.11 label for posterity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results.
Move the test files out of the test directory and rename the directory to fixtures.