[build] only strip public code, leave other assets #79504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Oct 5, 2020
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 7, 2020
Co-authored-by: spalger <[email protected]>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 7, 2020
Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Oct 7, 2020
…79899) Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
spalger
added a commit
that referenced
this pull request
Oct 7, 2020
…9898) Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77705
In #75841 we stripped the
publicdirectories from plugins because their code was already bundled and shipped with Kibana. This caused image assets which are served directly from the filesystem and not bundled with webpack to start 404ing in the build, which has been realized now that we're starting to look at snapshots more closely. This changes the copy-code filters for OSS and X-Pack to only skip js, ts, tsx, and JSON files, as those should all be imported by code in order to be included in the build. This leaves behind image and font files which can then be served directly from the file system.