Table visualization renderer #79455

sulemanof · 2020-10-05T13:17:25Z

Summary

Part of #46801

Implement a custom renderer for table visualization. This PR includes next changes:

implement toExpressionAst fn in this commit;
implement a custom legacy renderer in this file;
lazy load vis controller & styles;
visualization code base was moved into legacy folder as a preparation step for moving to react visualization in [Data table] Reactify & EUIficate the visualization #70801;
add unit tests;
enhanced types;

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

# Conflicts: # src/plugins/vis_type_table/public/legacy/vis_controller.ts # src/plugins/vis_type_table/public/table_vis_type.ts

elasticmachine · 2020-10-08T08:00:16Z

Pinging @elastic/kibana-app (Team:KibanaApp)

lukeelmers

Code LGTM! It feels so good to see lines being deleted from build_pipeline 🙌

cchaos

SASS file moves looks ok to me

alexwizp

LGTM! Thank you

ppisljar

app arch changes LGTM

stratoula · 2020-10-12T06:34:13Z

@elasticmachine merge upstream

stratoula · 2020-10-12T07:10:03Z

src/plugins/vis_type_table/public/to_ast.ts

+  schemas: ReturnType<typeof getVisSchemas>,
+  visParams: TableVisParams
+) => {
+  const visConfig = {} as any;


nit: I know that this any existed before but I was wondering if it can be easily typed.

I'll update this in a follow up pr here #70801 , if you don't mind.

You are the best!

stratoula

LGTM! ❤️

kibanamachine · 2020-10-12T08:14:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4f4571e

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`visTypeTable`	42	44	+2

async chunks size

id	before	after	diff
`visTypeTable`	6.7KB	70.6KB	+64.0KB

distributable file count

id	before	after	diff
`default`	48447	48453	+6
`oss`	29188	29194	+6

page load bundle size

id	before	after	diff
`visTypeTable`	78.1KB	20.2KB	-57.9KB
`visualizations`	273.5KB	272.7KB	-753.0B
total			-58.6KB

History

💚 Build #80475 succeeded 4e74b69
💔 Build #79670 failed 7b8a313
💔 Build #79596 failed 8053339

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Implement toExpressionAst fn * Implement table vis renderer, move legacy codebase * Update legacy paths * Update types * Fix filtering * Update styles * Remove legacy tests * Update docs * Update tests * Fix tests Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/plugins/expressions/public/kibana-plugin-plugins-expressions-public.iinterpreterrenderhandlers.md # docs/development/plugins/expressions/server/kibana-plugin-plugins-expressions-server.iinterpreterrenderhandlers.md # src/plugins/expressions/public/public.api.md # src/plugins/expressions/server/server.api.md

* master: (23 commits) Table visualization renderer (elastic#79455) Migrate Jest JUnit reporter to TS (elastic#79919) store sorted bundleRefExportIds (elastic#80011) update chromedriver dependency to 86.0.0 (elastic#79972) [Security Solution][Case] Fix bug when changing connectors (elastic#80002) [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752) [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038) [Logs UI] Sync logs timerange with wider Kibana (elastic#79444) [DOCS] Adds quick start (elastic#78822) [Ingest Manager]Fix ingest manager UI renaming (elastic#80036) [Monitoring] Fixed internal monitoring check (elastic#79241) [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871) Update development documentation about REST API best practices (elastic#80009) [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190) [CI] Move kibana build dir outside of repo for functional tests (elastic#80018) [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013) [Enterprise Search] Added a Credentials page to App Search (elastic#79749) [DOCS] Canvas refresh for 7.10 (elastic#80017) [TSVB] Add ignore global filters to series options (elastic#79337) Remove this check (elastic#79202) ...

* Implement toExpressionAst fn * Implement table vis renderer, move legacy codebase * Update legacy paths * Update types * Fix filtering * Update styles * Remove legacy tests * Update docs * Update tests * Fix tests Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/plugins/expressions/public/kibana-plugin-plugins-expressions-public.iinterpreterrenderhandlers.md # docs/development/plugins/expressions/server/kibana-plugin-plugins-expressions-server.iinterpreterrenderhandlers.md # src/plugins/expressions/public/public.api.md # src/plugins/expressions/server/server.api.md

sulemanof added 7 commits October 2, 2020 15:44

Implement toExpressionAst fn

3c62737

Implement table vis renderer, move legacy codebase

bf18625

Merge remote-tracking branch 'upstream/master' into feat/table_renderer

3870c90

Update legacy paths

074b02e

Update types

4b01fd3

Fix filtering

14ea04a

Update styles

8053339

sulemanof mentioned this pull request Oct 5, 2020

Renderers for all visualizations #46801

Closed

13 tasks

sulemanof added 5 commits October 5, 2020 16:41

Remove legacy tests

cd824df

Update docs

6e201e5

Update tests

7b8a313

Merge remote-tracking branch 'upstream/master' into feat/table_renderer

e7a6dbe

# Conflicts: # src/plugins/vis_type_table/public/legacy/vis_controller.ts # src/plugins/vis_type_table/public/table_vis_type.ts

Fix tests

4e74b69

sulemanof requested review from ppisljar, lukeelmers, stratoula, DianaDerevyankina, VladLasitsa and alexwizp October 8, 2020 07:59

sulemanof added Feature:Data Table Data table visualization feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0 labels Oct 8, 2020

sulemanof marked this pull request as ready for review October 8, 2020 08:00

sulemanof requested a review from a team October 8, 2020 08:00

sulemanof requested review from a team as code owners October 8, 2020 08:00

lukeelmers approved these changes Oct 8, 2020

View reviewed changes

botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Oct 8, 2020

cchaos approved these changes Oct 8, 2020

View reviewed changes

alexwizp approved these changes Oct 9, 2020

View reviewed changes

ppisljar approved these changes Oct 12, 2020

View reviewed changes

Merge branch 'master' into feat/table_renderer

4f4571e

stratoula reviewed Oct 12, 2020

View reviewed changes

stratoula approved these changes Oct 12, 2020

View reviewed changes

sulemanof merged commit b125472 into elastic:master Oct 12, 2020

sulemanof deleted the feat/table_renderer branch October 12, 2020 09:06

sulemanof mentioned this pull request Oct 12, 2020

[7.x] Table visualization renderer (#79455) #80121

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table visualization renderer #79455

Table visualization renderer #79455

sulemanof commented Oct 5, 2020 •

edited

Loading

elasticmachine commented Oct 8, 2020

lukeelmers left a comment

cchaos left a comment

alexwizp left a comment

ppisljar left a comment

stratoula commented Oct 12, 2020

stratoula Oct 12, 2020 •

edited

Loading

sulemanof Oct 12, 2020

stratoula Oct 12, 2020

stratoula left a comment

kibanamachine commented Oct 12, 2020

Table visualization renderer #79455

Table visualization renderer #79455

Conversation

sulemanof commented Oct 5, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 8, 2020

lukeelmers left a comment

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

alexwizp left a comment

Choose a reason for hiding this comment

ppisljar left a comment

Choose a reason for hiding this comment

stratoula commented Oct 12, 2020

stratoula Oct 12, 2020 • edited Loading

Choose a reason for hiding this comment

sulemanof Oct 12, 2020

Choose a reason for hiding this comment

stratoula Oct 12, 2020

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 12, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

distributable file count

page load bundle size

History

sulemanof commented Oct 5, 2020 •

edited

Loading

stratoula Oct 12, 2020 •

edited

Loading