[Monitoring] Thread pool rejections alert #79433
+1,149
−395
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import React, { useState } from 'react'; | ||
| import { EuiFormRow, EuiFieldNumber } from '@elastic/eui'; | ||
|
|
||
| interface Props { | ||
| name: string; | ||
| value: number; | ||
| label: string; | ||
| errors: string[]; | ||
| setAlertParams: (property: string, value: number) => void; | ||
| } | ||
| export const AlertParamNumber: React.FC<Props> = (props: Props) => { | ||
| const { name, label, setAlertParams, errors } = props; | ||
| const [value, setValue] = useState(props.value); | ||
| return ( | ||
| <EuiFormRow label={label} error={errors} isInvalid={errors?.length > 0}> | ||
| <EuiFieldNumber | ||
| compressed | ||
| value={value} | ||
| onChange={(e) => { | ||
| let newValue = Number(e.target.value); | ||
| if (isNaN(newValue)) { | ||
| newValue = 0; | ||
| } | ||
| setValue(newValue); | ||
| setAlertParams(name, newValue); | ||
| }} | ||
| /> | ||
| </EuiFormRow> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { EuiSpacer } from '@elastic/eui'; | ||
| import { Expression, Props } from '../components/duration/expression'; | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import { AlertTypeModel } from '../../../../triggers_actions_ui/public/types'; | ||
| import { CommonAlertParamDetails } from '../../../common/types'; | ||
|
|
||
| interface ThreadPoolTypes { | ||
| [key: string]: unknown; | ||
| } | ||
|
|
||
| interface ThreadPoolRejectionAlertClass { | ||
| TYPE: string; | ||
| LABEL: string; | ||
| PARAM_DETAILS: CommonAlertParamDetails; | ||
| } | ||
|
|
||
| export function createThreadPoolRejectionsAlertType( | ||
| threadPoolAlertClass: ThreadPoolRejectionAlertClass | ||
| ): AlertTypeModel { | ||
| return { | ||
| id: threadPoolAlertClass.TYPE, | ||
| name: threadPoolAlertClass.LABEL, | ||
| iconClass: 'bell', | ||
| alertParamsExpression: (props: Props) => ( | ||
| <> | ||
| <EuiSpacer /> | ||
| <Expression {...props} paramDetails={threadPoolAlertClass.PARAM_DETAILS} /> | ||
| </> | ||
| ), | ||
| validate: (inputValues: ThreadPoolTypes) => { | ||
| const errors: { [key: string]: string[] } = {}; | ||
| const value = inputValues.threshold as number; | ||
| if (value < 0) { | ||
| const errStr = i18n.translate('xpack.monitoring.alerts.validation.lessThanZero', { | ||
| defaultMessage: 'This value can not be less than zero', | ||
| }); | ||
| errors.threshold = [errStr]; | ||
| } | ||
|
|
||
| if (!inputValues.duration) { | ||
| const errStr = i18n.translate('xpack.monitoring.alerts.validation.duration', { | ||
| defaultMessage: 'A valid duration is required.', | ||
| }); | ||
| errors.duration = [errStr]; | ||
| } | ||
|
|
||
| return { errors }; | ||
| }, | ||
| defaultActionMessage: '{{context.internalFullMessage}}', | ||
| requiresAppContext: true, | ||
| }; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our unofficial goal is to ultimately limit all page load asset sizes to 200kb in the next year or so, as teams continue to work reducing the size of their bundles. Is anyone from the monitoring team working to reduce the page load asset size of this bundle? a 20kb increase feels reasonable for now, but I'd like to ask that someone from the monitoring team take a look at the
x-pack/plugins/monitoring/target/public/stats.jsonin one of the many webpack analyzers or visualizers after runningnode scripts/build_kibana_platform_plugins --focus monitoring --profile?When I run it I see that the server code is being bundles in the page load bundle, which seems like the best way to fix the limit issue, rather than raising the limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you @spalger 🙇