Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY_SOLUTION] rely on table in test for endpoint list kql bar #79402

Merged
merged 7 commits into from
Oct 5, 2020
Merged

[SECURITY_SOLUTION] rely on table in test for endpoint list kql bar #79402

merged 7 commits into from
Oct 5, 2020

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Oct 4, 2020 •
edited
Loading

Summary

Adjust test so that it looks at table to data to make a decision to check if data has updated. Also, change the method of inputting data into the query bar based on other tests in Kibana with the intention to make the test more reliable.

Issue: #77278

Checklist

Delete any items that are not applicable to this PR.

@kevinlog
Copy link
Contributor Author

kevinlog commented Oct 4, 2020

@elasticmachine merge upstream

@kevinlog kevinlog marked this pull request as ready for review October 5, 2020 11:43
@kevinlog kevinlog requested review from a team as code owners October 5, 2020 11:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@kevinlog kevinlog added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Oct 5, 2020
@kevinlog kevinlog changed the title Task/rely on table in test [SECURITY_SOLUTION] Task/rely on table in test Oct 5, 2020
paul-tavares
paul-tavares approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I assume you needed to change to keyboard interactions due to how the data plugin components work, right?

charlie-pichette
charlie-pichette approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@kevinlog kevinlog mentioned this pull request Oct 5, 2020
Closed
@kevinlog kevinlog merged commit 106ab7e into elastic:master Oct 5, 2020
@kevinlog kevinlog deleted the task/rely-on-table-in-test branch October 5, 2020 18:33
@kevinlog kevinlog changed the title [SECURITY_SOLUTION] Task/rely on table in test [SECURITY_SOLUTION] rely on table in test for endpoint list kql bar Oct 5, 2020
@kevinlog kevinlog mentioned this pull request Oct 5, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kevinlog added a commit that referenced this pull request Oct 5, 2020
@kevinlog
[SECURITY_SOLUTION] rely on table in test for endpoint list kql bar (#…
c402c7c 
…79402) (#79536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@charlie-pichette charlie-pichette charlie-pichette approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinlog @elasticmachine @kibanamachine @charlie-pichette @paul-tavares