-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate #79229
Merged
alvarezmelissa87
merged 2 commits into
elastic:master
from
alvarezmelissa87:ml-dfanalytics-creation-mml
Oct 6, 2020
Merged
[ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate #79229
alvarezmelissa87
merged 2 commits into
elastic:master
from
alvarezmelissa87:ml-dfanalytics-creation-mml
Oct 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
Feature:Data Frame Analytics
ML data frame analytics features
v7.10.0
labels
Oct 1, 2020
Pinging @elastic/ml-ui (:ml) |
...n/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/reducer.ts
Show resolved
Hide resolved
peteharverson
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM. Just left 1 suggestion.
alvarezmelissa87
force-pushed
the
ml-dfanalytics-creation-mml
branch
from
October 5, 2020 20:17
d754e4a
to
2c7099a
Compare
qn895
approved these changes
Oct 5, 2020
Tested and LGTM |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Oct 6, 2020
…model memory lower than estimate (elastic#79229) * allow user to create job when mml is lower than estimate * ensure mml validation works as expected
gmmorris
added a commit
that referenced
this pull request
Oct 8, 2020
…into feature/task_manager_429 * 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits) Add license check to direct package upload handler. (#79653) [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193) [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594) Fine-tunes ML related text on Metrics UI (#79425) [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229) Add new "Add Data" tutorials (#77237) Update APM telemetry docs (#79583) Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611) Kibana request headers (#79218) ensure missing indexPattern error is bubbled up to error callout (#79378) Missing space fix (#79585) remove duplicate tab states (#79501) [data.ui] Lazy load UI components in data plugin. (#78889) Add generic type params to search dependency. (#79608) [Ingest Manager] Internal action for policy reassign (#78493) [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175) [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579) [ML] Hide Data Grid column options when histogram charts are enabled. (#79459) [Telemetry] Synchronous `setup` and `start` methods (#79457) [Observability] Persist time range across apps (#79258) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #79179
Don't stop user from creating a job if the mml is lower than the estimated mml - show warning but allow user to continue.
Checklist
Delete any items that are not applicable to this PR.