-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core usage data #79101
Core usage data #79101
Conversation
@rudolf If it's not too late, can we please rename from "telemetry" to "usage data"? We're trying really hard to reserve using "Telemetry" for only sending the data to the service. We already have a |
Pinging @elastic/kibana-platform (Team:Platform) |
|
|
||
export interface CoreUsageData { | ||
config: CoreConfigUsageData; | ||
// services: CoreServicesUsageData; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the telemetry team asked us not to use ...Telemetry
I've switched to ...UsageData
but CoreUsageData['usageData']
is a bit awkward, so I deviated from the "spec" in the original issue by using the key "services" with the idea that we would group usage data under the respective Core services they originate from e.g. savedObjects / plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Just added a couple of NITs.
Reading through your PR, I acknowledge we (the telemetry team) need to work on our documentation 😅
src/plugins/kibana_usage_collection/server/collectors/core/core_usage_collector.ts
Outdated
Show resolved
Hide resolved
src/plugins/kibana_usage_collection/server/collectors/core/core_usage_collector.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested with localhost:5601/api/stats?extended and it seemed to work correctly 😄. A couple small nits is all.
src/plugins/kibana_usage_collection/server/collectors/core/core_usage_collector.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
* Core usage data (#79101) * Core Telemetry service * CoreTelemetryService mock * Add missing config values back, cleanup * Core usage collector * HttpConfig path is 'server' * Fix tests * CoreTelemetry -> CoreUsageData * Improve tests / docs * Fix telemetry_check * Don't catch fetch function exceptions, let usage collector handle it * Code review * Collect saved object index usage data * Fix tests and telemetry_check * explicitly import/export usage data types for telemetry_check * Remove OS data for now, test for SO usage data * Fix tests * Polish core docs * This shouldn't be here * Fix test
Summary
Core Telemetry Service for supplying core metrics to a usage collector (usage collector not implemented yet). I aimed to collect the easy metrics to get this in before FF, but this doesn't collect all the metrics we identified in #56762
Checklist
Delete any items that are not applicable to this PR.
For maintainers