Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.10][Telemetry] Display collected security event sample #78963

Merged
merged 9 commits into from
Oct 2, 2020
Merged

[7.10][Telemetry] Display collected security event sample #78963

merged 9 commits into from
Oct 2, 2020

Conversation

pjhampton
Copy link
Contributor

@pjhampton pjhampton commented Sep 30, 2020

Resolves #68942
Related to #77200
Related to #78262 (Closed PR)

Summary

This PR adds a fly-out with an example of a security event collected from Elastic Endpoint when enabled.
Discussion items from #78262

  • There is an issue where the panel isn't showing up the categories filter. This won't be fixed here.
  • A separate fly-out is the approach we are going for.
  • The Security Event payload is static and won't change.

Screenshot 2020-09-30 at 15 48 29

Screenshot 2020-09-30 at 15 48 41

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Comment on lines 208 to 211
clusterData: <EuiLink onClick={this.toggleExample}>cluster data</EuiLink>,
endpointSecurityData: (
<EuiLink onClick={this.toggleSecurityExample}>endpoint security data</EuiLink>
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add new translation IDs for cluster data and endpoint security data as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated in 0fae604

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pjhampton
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reviewing under the assumption that endpoint was still a product and shouldn't be translated 🤦‍♀️ . Good catch!
LGTM

@pjhampton pjhampton merged commit e52884c into elastic:master Oct 2, 2020
@pjhampton pjhampton deleted the @pjhampton/68942 branch October 2, 2020 09:28
pjhampton added a commit that referenced this pull request Oct 2, 2020
…79293)

* Add security example to usage data opt in panel.

* Update translations.

* Fix docs.

* Fix broken type.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 10, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Jest Integration Tests.packages/kbn-plugin-helpers/src/integration_tests.builds a generated plugin into a viable archive

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/89079


Stack Trace

Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `builds a generated plugin into a viable archive 2`

- Snapshot  - 0
+ Received  + 3

  " info deleting the build and target directories
   info running @kbn/optimizer
   │ info initialized, 0 bundles cached
   │ info starting worker [1 bundle]
+  │ warn worker stderr Browserslist: caniuse-lite is outdated. Please run:
+  │ warn worker stderr npx browserslist@latest --update-db
+  │ warn worker stderr Browserslist: caniuse-lite is outdated. Please run the following command: `yarn upgrade`
   │ succ 1 bundles compiled successfully after <time>
   info copying source into the build and converting with babel
   info running yarn to install dependencies
   info compressing plugin into [fooTestPlugin-7.5.0.zip]"
    at Object.<anonymous>.it (/dev/shm/workspace/parallel/3/kibana/packages/kbn-plugin-helpers/src/integration_tests/build.test.ts:74:25)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [36814aa]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow additional solutions to take advantage of the telemetry opt-in
6 participants