Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y tests for filter panel #78776

Merged
merged 9 commits into from
Sep 30, 2020
Merged

A11y tests for filter panel #78776

merged 9 commits into from
Sep 30, 2020

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Sep 29, 2020 •
edited
Loading

Meta issue - #51456
a11y tests for filter panel

@bhavyarm bhavyarm mentioned this pull request Sep 29, 2020
Open
77 tasks
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm self-assigned this Sep 29, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id value diff baseline
data 1.3MB +69.0B 1.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review September 29, 2020 22:58
@bhavyarm bhavyarm requested a review from a team as a code owner September 29, 2020 22:58
tsullivan
tsullivan approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for App Arch owned code

rashmivkulkarni
rashmivkulkarni approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review only

LeeDr
LeeDr approved these changes Sep 30, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only code review and Jenkins results

@bhavyarm bhavyarm merged commit 8e963fd into elastic:master Sep 30, 2020
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Sep 30, 2020
@bhavyarm
A11y tests for filter panel (elastic#78776)
82c37de 
a11y tests for filter panel and some test data un mounting
@bhavyarm bhavyarm mentioned this pull request Sep 30, 2020
Merged
@bhavyarm bhavyarm added the Team:QA Team label for QA Team label Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

bhavyarm added a commit that referenced this pull request Sep 30, 2020
@bhavyarm
A11y tests for filter panel (#78776) (#78953)
6fe5ed5 
a11y tests for filter panel and some test data unmounting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@rashmivkulkarni rashmivkulkarni rashmivkulkarni approved these changes

@streamich streamich streamich approved these changes

@wayneseymour wayneseymour wayneseymour approved these changes

@myasonik myasonik myasonik approved these changes

@tsullivan tsullivan tsullivan approved these changes

Assignees

@bhavyarm bhavyarm

Labels
Feature:Filters Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bhavyarm @kibanamachine @elasticmachine @tsullivan @myasonik @wayneseymour @streamich @rashmivkulkarni @LeeDr