-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Unskip doc link functional test #78600
Merged
kertal
merged 6 commits into
elastic:master
from
kertal:kertal-pr-2020-09-28-unskip-doc-view-open-functional-test
Oct 1, 2020
Merged
[Discover] Unskip doc link functional test #78600
kertal
merged 6 commits into
elastic:master
from
kertal:kertal-pr-2020-09-28-unskip-doc-view-open-functional-test
Oct 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@elasticmachine merge upstream |
kertal
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
:KibanaApp/fix-it-week
v7.10.0
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Sep 30, 2020
Pinging @elastic/kibana-app (Team:KibanaApp) |
spalger
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Oct 1, 2020
* Flaky test runner confirmed it's not flaky
kertal
added a commit
that referenced
this pull request
Oct 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 1, 2020
* master: (36 commits) [I18n] fix eui tokens (elastic#78951) Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768) Make the actual Vislib import async (elastic#78949) Fix ML conditionals links Cypress tests (elastic#78568) [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761) [UX] Improve page-load axis (elastic#78392) [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610) Data plugin README (elastic#78750) [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009) fixing api test (elastic#78964) [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129) [Loggers] Rename "telemetry" to "usage" (elastic#78130) [Usage Collection] [schema] `ui_metric` (elastic#78827) [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772) [Discover] Unskip doc link functional test (elastic#78600) [ML] Functional tests - stabilize calendar edit tests (elastic#78950) [UX] Improve page responsive (elastic#78759) [QA][Code Coverage] Team Assignment Docs Update (elastic#78890) [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (elastic#78209) [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Discover
Discover Application
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unskipping Discover doc link functional test
This test doesn't seem to be flaky:
200 runs, just the test suite
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/859/
100 runs, oss:ciGroup:6
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/870/
Fixes #78373
Note that there are other test cases failed in a similar flaky way,
Error loading data
, like this#39842
I've improved the error message to provide more info her:
#78587
Fixes #78373