Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Kibana nav when docked overlaps the content of the pages. #78593

Merged
merged 3 commits into from
Sep 30, 2020
Merged

[Observability] Kibana nav when docked overlaps the content of the pages. #78593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8806a1b
adding padding left
cauemarcondes Sep 28, 2020
e6bdcac
Merge branch 'master' of github.com:elastic/kibana into obs-docked-nav
cauemarcondes Sep 30, 2020
18aa24b
adding space left to appSection
cauemarcondes Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/observability/public/components/app/header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const Wrapper = styled.div<{ restrictWidth?: number }>`
max-width: ${(props) => `${props.restrictWidth}px`};
margin: 0 auto;
overflow: hidden;
padding: ${(props) => (props.restrictWidth ? 0 : '0 24px')};
padding: 0 16px;
`;

interface Props {
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/observability/public/components/app/layout/with_header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,8 @@ import React from 'react';
import styled from 'styled-components';
import { Header } from '../header/index';

const getPaddingSize = (props: EuiPageProps) => (props.restrictWidth ? 0 : '24px');

const Page = styled(EuiPage)<EuiPageProps>`
background: transparent;
padding-right: ${getPaddingSize};
padding-left: ${getPaddingSize};
`;

const Container = styled.div<{ color?: string }>`
Expand Down
5 changes: 3 additions & 2 deletions x-pack/plugins/observability/public/pages/landing/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { WithHeaderLayout } from '../../components/app/layout/with_header';
import { usePluginContext } from '../../hooks/use_plugin_context';
import { useTrackPageview } from '../../hooks/use_track_metric';
import { appsSection } from '../home/section';
import './styles.scss';

const EuiCardWithoutPadding = styled(EuiCard)`
padding: 0;
Expand All @@ -43,7 +44,7 @@ export function LandingPage() {
>
<EuiFlexGroup direction="column">
{/* title and description */}
<EuiFlexItem style={{ maxWidth: '50%' }}>
<EuiFlexItem className="obsLanding__title">
<EuiTitle size="s">
<h2>
{i18n.translate('xpack.observability.home.sectionTitle', {
Expand All @@ -65,7 +66,7 @@ export function LandingPage() {
<EuiSpacer size="s" />
<EuiFlexGroup>
<EuiFlexItem>
<EuiFlexGrid columns={2}>
<EuiFlexGrid columns={2} className="obsLanding__appSection">
{appsSection.map((app) => (
<EuiFlexItem key={app.id}>
<EuiCardWithoutPadding
Expand Down
12 changes: 12 additions & 0 deletions x-pack/plugins/observability/public/pages/landing/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
.obsLanding__appSection .euiFlexItem {
@include euiBreakpoint('xs', 's', 'm', 'l') {
// overrides .euiFlexItem flex basis
flex-basis: 100% !important;
}
}

.obsLanding__title {
@include euiBreakpoint('m', 'l', 'xl') {
max-width: 50%;
}
}