Omit runtime fields from FLS suggestions #78330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
release_note:enhancement
Team:Security
legrego
commented
Sep 24, 2020
| @@ -8,6 +8,20 @@ import { schema } from '@kbn/config-schema'; | |||
| import { RouteDefinitionParams } from '../index'; | |||
| import { wrapIntoCustomErrorResponse } from '../../errors'; | |||
|
|
|||
| interface FieldMappingResponse { | |||
There was a problem hiding this comment.
Improved type safety, at least until we can migrate away from the legacy ES client.
|
Pinging @elastic/kibana-security (Team:Security) |
|
@elasticmachine merge upstream |
|
ACK: will review today |
azasypkin
approved these changes
Sep 30, 2020
| // 4. Use `Set` to get only unique field names. | ||
| const fields = Array.from( |
There was a problem hiding this comment.
question: how do you feel about adding a simple jest test to test this logic?
|
|
||
| const isRuntimeField = hasMapping && mappingValues[0]?.type === 'runtime'; | ||
|
|
||
| // fields without mappings are internal fields such as `_routing` and `_index`, |
Co-authored-by: Aleh Zasypkin <[email protected]>
…omit-runtime-fields
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
legrego
added a commit
that referenced
this pull request
Oct 1, 2020
Co-authored-by: Aleh Zasypkin <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Aleh Zasypkin <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 7, 2020
This reverts commit 4525f0c.
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 7, 2020
elastic#79106)" This reverts commit f0be469.
spalger
added a commit
that referenced
this pull request
Oct 7, 2020
…) (#79939) Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Runtime fields are not securable via FLS - it's technically possible to assign them as a granted/denied field, but this is effectively a no-op. In order to avoid confusion, we are updating the list of available options to omit runtime fields.
Resolves #78329