Guide users to +1 with thumbs up reaction emoji #7821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure wording of Contributing doc guides users to favour the thumbs up reaction emoji rather than using +1 text comment. A long stream of text +1 comments will ping all the watchers of the thread and also cause a long comment thread that is unnecessary and distracting.
|
I see a typo in my PR:
should be
|
|
@geekpete we just made some updates to the contributing.md file overall, and I tried to incorporate these thoughts. How does this look? https://github.com/elastic/kibana/pull/7856/files#diff-6a3371457528722a734f3c51d9238c13R44 |
|
LGTM! :) |
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Aug 23, 2016
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Aug 23, 2016
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Aug 23, 2016
Added percentage option to significant_terms agg Significant terms: add scriptable significance heuristic elastic#7850 Add `format` support for date range filter and queries elastic#7821 Add `min_score` parameter to function score query to only match docs
|
It's not an issue that people comment with the +1 rather than using a reaction. If that's how people want to express their support for a ticket, then that's what they should do. Folks can always unsubscribe if they don't want the notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure wording of Contributing doc guides users to favour the thumbs up reaction emoji rather than using +1 text comment.
A long stream of text +1 comments will ping all the watchers of the thread and also cause a long comment thread that is unnecessary and distracting.