Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Auto' interval must be correctly calculated for natural numbers #77995

Merged
merged 5 commits into from
Sep 23, 2020
Merged

'Auto' interval must be correctly calculated for natural numbers #77995

merged 5 commits into from
Sep 23, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Sep 21, 2020 •
edited
Loading

Closes: #78032

Summary

This PR based on #77023 (comment)

For cases (valid only for natural(integer) numbers) where the difference between the maximum and minimum is less than the MaxBars value, we set the float value. This is not correct, the value must be a natural number and equal to 1

Steps to reproduce:

  1. install kibana_sample_data_ecommerce sample data
  2. create one of our base visualizations
  3. set Last 7 days timeframe
  4. add Histogram aggregation by day_of_week_i field
    image

Actual:

image

Expected:

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Sep 21, 2020
@alexwizp alexwizp added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes labels Sep 21, 2020
@alexwizp alexwizp marked this pull request as ready for review September 21, 2020 19:41
@alexwizp alexwizp requested a review from a team as a code owner September 21, 2020 19:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon
wylieconlon approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
data 1.5MB +654.0B 1.5MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lukeelmers
lukeelmers approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@alexwizp alexwizp merged commit 62c095b into elastic:master Sep 23, 2020
@alexwizp alexwizp mentioned this pull request Sep 23, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Sep 23, 2020
@alexwizp @elasticmachine
'Auto' interval must be correctly calculated for natural numbers (ela…
63603ae 
…stic#77995)

* 'Auto' interval must be correctly calculated for natural numbers

* fix ts error

* fix PR comments

Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit that referenced this pull request Sep 23, 2020
@alexwizp @elasticmachine
'Auto' interval must be correctly calculated for natural numbers (#77995
e63cb13 
) (#78251)

* 'Auto' interval must be correctly calculated for natural numbers

* fix ts error

* fix PR comments

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 23, 2020
@gmmorris
Merge branch 'master' into actions/pagerduty-dedup
097b99d 
* master: (31 commits)
  skip tests for old pacakge (elastic#78194)
  [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872)
  [Lens] Rename "telemetry" to "stats" (elastic#78125)
  [CSM] Url search (elastic#77516)
  [Drilldowns] Config to disable URL Drilldown  (elastic#77887)
  [Lens] Combined histogram/range aggregation for numbers (elastic#76121)
  Remove legacy plugins support (elastic#77599)
  'Auto' interval must be correctly calculated for natural numbers (elastic#77995)
  [CSM] fix ingest data retry order messed up (elastic#78163)
  Add response status helpers (elastic#78006)
  Bump react-beautiful-dnd (elastic#78028)
  [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004)
  Index pattern  - refactor constructor (elastic#77791)
  Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192)
  Remove [key: string]: any; from IIndexPattern (elastic#77968)
  Remove requirement for manage_index_templates privilege for Index Management (elastic#77377)
  [Ingest Manager] Agent bulk actions UI (elastic#77690)
  [Metrics UI] Add inventory view timeline (elastic#77804)
  Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101)
  Update to latest rum-react (elastic#78193)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes left review comments

@wylieconlon wylieconlon wylieconlon approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to handle floating intervals in histogram's auto interval
6 participants
@alexwizp @elasticmachine @kibanamachine @wylieconlon @timroes @lukeelmers