[data.search] Move SearchSource to common directory. #77823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
lukeelmers
force-pushed
the
fix/ssource-to-common
branch
from
9933faf to
78c3c14
Compare
lukeelmers
force-pushed
the
fix/ssource-to-common
branch
from
78c3c14 to
88dec35
Compare
lukeelmers
commented
Sep 17, 2020
| describe('defaultSearchStrategy', function () { | ||
| describe('search', function () { | ||
| describe('defaultSearchStrategy', () => { | ||
| describe('search', () => { |
There was a problem hiding this comment.
In this test file, I needed to move a few things around because it was testing callMsearch, which lives in public. So I instead mocked callMsearch and simply tested that the function was called with the correct args.
Then I moved the existing logic asserting that http.post was called correctly into a separate unit test which lives alongside callMsearch.
Comment on lines
+20
to
+35
| import { Observable } from 'rxjs'; | ||
| import { IEsSearchRequest, IEsSearchResponse, ISearchOptions } from '../../common/search'; | ||
|
|
||
| export type ISearch = ( | ||
| request: IKibanaSearchRequest, | ||
| options?: ISearchOptions | ||
| ) => Observable<IKibanaSearchResponse>; | ||
|
|
||
| export type ISearchGeneric = < | ||
| SearchStrategyRequest extends IEsSearchRequest = IEsSearchRequest, | ||
| SearchStrategyResponse extends IEsSearchResponse = IEsSearchResponse | ||
| >( | ||
| request: SearchStrategyRequest, | ||
| options?: ISearchOptions | ||
| ) => Observable<SearchStrategyResponse>; | ||
|
|
There was a problem hiding this comment.
For the purposes of this PR, these were the only types from public/search/types which needed to be relocated to common.
lukeelmers
added
Feature:Search
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
nreese
approved these changes
Sep 17, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Sep 18, 2020
lukeelmers
added a commit
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65069
This is the second-to-last PR in migrating SearchSource to the server. To keep things simple, all this PR does is relocate the various files required by SearchSource from the
publicdirectory to thecommondirectory, and update imports accordingly.data/public/search/search_sourcemoved tocommonmapsandvisualizationspluginsfetchandlegacydirectories nested inside ofsearch_sourcesince they aren't used externallycommonimporting code frompublic(see review notes)The next/final PR will actually handle exposing the service on the server.
No functional changes have been introduced here; just moving code around.