-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize: Bad request when working with histogram aggregation #77684
Conversation
Code here makes sense, but we should also add unit and/or functional tests for this case. |
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Removed myself as reviewer as I contributed to the PR 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM, thanks for adding that test!
Tested on chrome (macOS), and seems to be working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on safari
…ic#77684) * Visualize: Bad request when working with histogram aggregation Closes: elastic#77023 * ✏️ Add some more fix context * ✅ Add test Co-authored-by: dej611 <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
… (#77850) * Visualize: Bad request when working with histogram aggregation Closes: #77023 * ✏️ Add some more fix context * ✅ Add test Co-authored-by: dej611 <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: dej611 <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: (92 commits) [ILM] Data tiers for 7.10 (elastic#76126) [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789) [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654) Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746) [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598) [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688) fixed react warning in Suspense in alert flyout (elastic#77777) [APM] Track usage of Gold+ features (elastic#77630) Visualize: Bad request when working with histogram aggregation (elastic#77684) remove legacy ES plugin (elastic#77703) [Lens] change name of custom query to filters (elastic#77725) skip flaky suite (elastic#76239) remove visual aspects of baseline job (elastic#77815) skip flaky suite (elastic#77835) Fixes typo in data recognizer text (elastic#77691) management/update trusted_apps jest snapshot [build] Use Elastic hosted UBI minimal base image (elastic#77776) [APM] Add transaction error rate alert (elastic#76933) [Security Solution] [Detections] Remove file validation on import route (elastic#77770) [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698) ...
Closes: #77023
Summary
When changing the settings for the histogram aggregation, it's possible to run into a state no interval is provided
Steps to reproduce:
Checklist
Delete any items that are not applicable to this PR.
For maintainers