Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded forced package resolutions #77467

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Sep 15, 2020

The removed resolutions are no longer needed because the packages that originally depended on the incompatible versions have either been removed or upgraded.

The removed resolutions are no longer needed because the packages that
originally depended on the incompatible versions have either been
removed or upgraded.
@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 15, 2020
@watson watson self-assigned this Sep 15, 2020
@watson watson requested review from a team September 15, 2020 12:04
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested locally to ensure that running yarn kbn bootstrap doesn't change the lockfile.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
enterpriseSearch 434.2KB -389.0B 434.6KB

page load bundle size

id value diff baseline
upgradeAssistant 64.5KB -389.0B 64.9KB

distributable file count

id value diff baseline
default 45909 -9 45918
oss 27709 -9 27718
total -18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit b733375 into elastic:master Sep 17, 2020
@watson watson deleted the resolutions-cleanup branch September 17, 2020 08:58
watson added a commit to watson/kibana that referenced this pull request Sep 17, 2020
The removed resolutions are no longer needed because the packages that
originally depended on the incompatible versions have either been
removed or upgraded.
watson added a commit that referenced this pull request Sep 17, 2020
The removed resolutions are no longer needed because the packages that
originally depended on the incompatible versions have either been
removed or upgraded.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants