[APM] Use apm_8.0.0 archive where possible #77450
Conversation
dgieselaar
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
dgieselaar
force-pushed
the
use-main-archive
branch
from
aaf3c86 to
256d46b
Compare
| @@ -10,6 +10,8 @@ export default function ApiTest({ getService }: FtrProviderContext) { | |||
| const supertest = getService('supertest'); | |||
| const esArchiver = getService('esArchiver'); | |||
|
|
|||
| const archiveName = 'apm_8.0.0'; | |||
There was a problem hiding this comment.
As mentioned I think we should pin this to a specific version.
The current change is a good example: archive 8.0.0 is being replaced by archive 8.0.0. It's impossible to see what changed. At a minimum we should have a date that accompanies the archive if we choose a non-released, floating version.
There was a problem hiding this comment.
Btw. why is the archive called apm_8.0.0? Is the apm prefix needed to distinguish from other solutions' archives?
There was a problem hiding this comment.
This is actually not an archive update, but simply using our main archive. Fwiw, if we have a more specific version in our name, it will be harder for us to automate an archive update.
There was a problem hiding this comment.
I don't think we need it, I think my intention was to distinguish from other archives like the observability one.
There was a problem hiding this comment.
okay i see it's not an archive update (they both already exist) but how do we distinguish between the two?
I assume we want to delete the old one?
Fwiw, if we have a more specific version in our name, it will be harder for us to automate an archive update.
Would this also be the case if we prefix it with a date?
There was a problem hiding this comment.
@sqren I would like to delete 8.0.0, but it's used in conjunction with rum_8.0.0, and I don't know what's in the latter. (I could find out, but for this PR I want to improve coverage of the main/apm_8.0.0 archive so I can upgrade it in a second PR, in preparation for the Metric Powered KPIs tests). Would you be okay with me opening up an issue around archive naming? I can pick it up after I merge Metric Powered KPIs.
There was a problem hiding this comment.
Sure feel free to merge. I don't think we need an issue for this. But having two almost identically named archives is going to cause confusion so we should fix it.
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
No description provided.