-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions][Case] Settings per case per connector #77327
Conversation
ccc076d
to
f292f95
Compare
81347fc
to
027e8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally, migration has been working as expected. I was able to create/update cases with these new settings fields. I review the code and I thought the fields registry is a great way of implementation. It will be easy to add new connectors and features on top of it.
@stephmilovic did also a good job by refactoring code and spending time fixing bugs and clean up the code. Great teamwork here!!! never easy when you have the pressure of feature freeze.
I think we can all feel like Christos today ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) (#79716) Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Steph Milovic <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
page load bundle size
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
@cnasikas For this PR to be included in the breaking changes doc, I need a write up that includes the details and impact of the change. See this breaking changes doc for an example. |
@cjcenizal Thanks for your feedback. I updated the description accordingly and improve the labeling for the release note. |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
This PR allows users to specify connector incident fields when cases are being sent to them. Specifically:
Ref: #76222, #76212, #75622
Dev docs
POST <kibana host>:<port>/api/cases
) you need to provide aconnector
. Requests without aconnector
response to400 Bad Request
.PATCH <kibana host>:<port>/api/cases
) you need to provide theconnector
. The previouslyconnector_id
attribute has been removed in favor of theconnector
attribute.POST <kibana host>:<port>/api/cases/configure
) you need to provide aconnector
. The previouslyconnector_id
andconnector_name
attributes have been removed in favor of theconnector
attribute.PATCH <kibana host>:<port>/api/cases/configure
) you need to provide aconnector
. The previouslyconnector_id
andconnector_name
attributes have been removed in favor of theconnector
attribute.Connector schema:
connector
.servicenow
,jira
,.resilient
, and.none
fields
For ServiceNow connectors:
For Jira connectors:
For IBM Resilient connectors:
Checklist
Delete any items that are not applicable to this PR.
For maintainers