Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] show meta field data in Lens #77210

Merged
merged 17 commits into from
Sep 24, 2020
Merged

[Lens] show meta field data in Lens #77210

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cbb4db0
show meta field data in Lens
flash1293 Sep 10, 2020
58ffcb4
add comment
flash1293 Sep 10, 2020
3c0730e
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 14, 2020
0ad5d18
add separate section for meta fields
flash1293 Sep 14, 2020
1aa9b94
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 15, 2020
eb19274
fix api tests
flash1293 Sep 15, 2020
dcc3fc3
commit current state
flash1293 Sep 16, 2020
4772717
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 16, 2020
1592748
create general fieldlist component handling arbitrary number of accor…
flash1293 Sep 16, 2020
08164ef
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 16, 2020
01e29f7
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 17, 2020
fed77da
review comments
flash1293 Sep 17, 2020
fdc9d2b
fix scss
flash1293 Sep 17, 2020
52fd78d
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 21, 2020
a642ac9
Merge remote-tracking branch 'upstream/master' into lens/system-fields
flash1293 Sep 23, 2020
3013d99
memoize field groups
flash1293 Sep 23, 2020
7ee7bbb
improve performance
flash1293 Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions x-pack/plugins/lens/public/indexpattern_datasource/datapanel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,6 @@
margin-bottom: $euiSizeS;
}

/**
* 1. Don't cut off the shadow of the field items
*/

.lnsInnerIndexPatternDataPanel__listWrapper {
@include euiOverflowShadow;
@include euiScrollBar;
margin-left: -$euiSize; /* 1 */
position: relative;
flex-grow: 1;
overflow: auto;
}

.lnsInnerIndexPatternDataPanel__list {
padding-top: $euiSizeS;
position: absolute;
top: 0;
left: $euiSize; /* 1 */
right: $euiSizeXS; /* 1 */
}

.lnsInnerIndexPatternDataPanel__fieldItems {
// Quick fix for making sure the shadow and focus rings are visible outside the accordion bounds
padding: $euiSizeXS $euiSizeXS 0;
Expand Down
35 changes: 32 additions & 3 deletions x-pack/plugins/lens/public/indexpattern_datasource/datapanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,11 +623,40 @@ describe('IndexPattern Data Panel', () => {
).toEqual(['client', 'source', 'timestampLabel']);
});

it('should show meta fields accordion', async () => {
const wrapper = mountWithIntl(
<InnerIndexPatternDataPanel
{...props}
indexPatterns={{
'1': {
...props.indexPatterns['1'],
fields: [
...props.indexPatterns['1'].fields,
{ name: '_id', displayName: '_id', meta: true, type: 'string' },
],
},
}}
/>
);
wrapper
.find('[data-test-subj="lnsIndexPatternMetaFields"]')
.find('button')
.first()
.simulate('click');
expect(
wrapper
.find('[data-test-subj="lnsIndexPatternMetaFields"]')
.find(FieldItem)
.first()
.prop('field').name
).toEqual('_id');
});

it('should display NoFieldsCallout when all fields are empty', async () => {
const wrapper = mountWithIntl(
<InnerIndexPatternDataPanel {...defaultProps} existingFields={{ idx1: {} }} />
);
expect(wrapper.find(NoFieldsCallout).length).toEqual(1);
expect(wrapper.find(NoFieldsCallout).length).toEqual(2);
expect(
wrapper
.find('[data-test-subj="lnsIndexPatternAvailableFields"]')
Expand All @@ -654,7 +683,7 @@ describe('IndexPattern Data Panel', () => {
.length
).toEqual(1);
wrapper.setProps({ existingFields: { idx1: {} } });
expect(wrapper.find(NoFieldsCallout).length).toEqual(1);
expect(wrapper.find(NoFieldsCallout).length).toEqual(2);
});

it('should filter down by name', () => {
Expand Down Expand Up @@ -699,7 +728,7 @@ describe('IndexPattern Data Panel', () => {
expect(wrapper.find(FieldItem).map((fieldItem) => fieldItem.prop('field').name)).toEqual([
'Records',
]);
expect(wrapper.find(NoFieldsCallout).length).toEqual(2);
expect(wrapper.find(NoFieldsCallout).length).toEqual(3);
});

it('should toggle type if clicked again', () => {
Expand Down
Loading