Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor app-switcher links components. #7711

Merged
merged 6 commits into from
Jul 27, 2016
Merged

Refactor app-switcher links components. #7711

merged 6 commits into from
Jul 27, 2016

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jul 11, 2016 •
edited
Loading

Helps clear the path for #7467

@cjcenizal cjcenizal changed the title WIP [7467]: Allow user to pin/unpin the sidebar. Refactor app-switcher links components. Jul 11, 2016
@ycombinator ycombinator self-assigned this Jul 11, 2016
@cjcenizal cjcenizal mentioned this pull request Jul 12, 2016
Merged
@cjcenizal
Copy link
Contributor Author

jenkins, test this

1 similar comment
@cjcenizal
Copy link
Contributor Author

jenkins, test this

@panda01 panda01 self-assigned this Jul 13, 2016
@panda01
Copy link
Contributor

panda01 commented Jul 14, 2016 •
edited
Loading

Hmm, looks like there are some style problems with active or something or another, this happens when kibana redirects back to settings with no index pattern configured, after i click on another page.

black-text

@epixa epixa assigned cjcenizal and unassigned panda01 Jul 19, 2016
@epixa
Copy link
Contributor

epixa commented Jul 23, 2016

In addition to the above feedback, this needs to be rebased or have master merged into it.

@cjcenizal
Copy link
Contributor Author

Khalah's bug was being caused by inherited anchor tag styles. I fixed this in the LESS.

@ycombinator
Copy link
Contributor

ycombinator commented Jul 26, 2016 •
edited
Loading

I tested this with x-pack installed. I'm seeing some bad styling on the username + logout button area at the bottom of the left nav:

Contracted:
screen shot 2016-07-26 at 7 14 11 am

Expanded:
screen shot 2016-07-26 at 7 14 18 am

Here's what it should look like (i.e. how it looks like with master):

Contracted:
screen shot 2016-07-26 at 7 12 47 am

Expanded:
screen shot 2016-07-26 at 7 12 54 am

@cjcenizal
Copy link
Contributor Author

jenkins, test this

@bevacqua
Copy link
Contributor

LGTM

@bevacqua bevacqua removed their assignment Jul 26, 2016
ycombinator
ycombinator reviewed Jul 26, 2016
View reviewed changes
src/ui/public/chrome/directives/app_switcher_link/app_switcher_link.less
color: #ebf7fa;

/**
* 1. TODO: Override anchor styles. Fix this by removing a tag styles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just wanted to make sure some cleanup wasn't necessary.

@ycombinator
Copy link
Contributor

LGTM!

👏 for the tests!

@ycombinator ycombinator removed their assignment Jul 27, 2016
@cjcenizal cjcenizal merged commit 16ecfc2 into elastic:master Jul 27, 2016
@cjcenizal cjcenizal deleted the 7467/pin-sidebar branch July 27, 2016 18:22
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@cjcenizal
Merge pull request elastic#7711 from cjcenizal/7467/pin-sidebar
4fb5035 
Refactor app-switcher links components.

Former-commit-id: 16ecfc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjcenizal cjcenizal

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjcenizal @panda01 @epixa @ycombinator @bevacqua @simianhacker