[Discover] Change context query to prevent duplicates #77014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
…-09-discover-context-query-change
…github.com:kertal/kibana into kertal-pr-2020-09-09-discover-context-query-change
…-09-discover-context-query-change
kertal
added
:KibanaApp/fix-it-week
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dej611
approved these changes
Oct 1, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Oct 2, 2020
kertal
added a commit
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additionally to the cases that were fixed in #38873 there could be a
duplicates in a repeater are not allowederror when the same document is returned with different_docvalues. The value of_doccan differ e.g. if the same ES replica isn't used for 2 requests, or if there's a merge occurring between 2 requests (Context uses several requests to build the list, and in the error case the anchor document is also returned in the previous/next documents, with a different_docvalue, so the internal id that Angular uses to track the displayed records is no longer unique). This solution filters out the anchor document of the previous and next documents.fixes #76283
Note about testing: there is no good way to test this, AFAIK there is no reliable way to reproduce the state of differing
_docvaluesChecklist
Delete any items that are not applicable to this PR.