Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Replace panel flyout opens 2 flyouts #76931

Merged
merged 2 commits into from
Sep 10, 2020
Merged

[bugfix] Replace panel flyout opens 2 flyouts #76931

merged 2 commits into from
Sep 10, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 8, 2020 •
edited
Loading

Summary

Closes #64789 (for 2nd time)

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 8, 2020
@Dosant Dosant mentioned this pull request Sep 8, 2020
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
dashboard 711.4KB -62.0B 711.5KB
uiActions 218.5KB -97.0B 218.6KB
total -159.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant marked this pull request as ready for review September 8, 2020 14:33
@Dosant Dosant requested a review from a team September 8, 2020 14:33
@Dosant Dosant requested a review from a team as a code owner September 8, 2020 14:33
streamich
streamich approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@streamich
Copy link
Contributor

streamich commented Sep 9, 2020 •
edited
Loading

The best approach would be to structure code such that the code that needs to open the flyout uses directly the EUI component, like

const Comp = () => {
  return (
    <div>
      // ...
      {doOpen && (<EuiFlyout> ...)}
      // ...
    </div>
  );
};

instead of imperatively calling .openFlyout().

ThomThomson
ThomThomson approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on chrome, and everything works as expected!

LGTM

@Dosant Dosant merged commit 2f4d059 into elastic:master Sep 10, 2020
@Dosant Dosant mentioned this pull request Sep 10, 2020
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Sep 10, 2020
@Dosant
[bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
aadac19 
* fix replace panel flyout opens 2 flyouts

* fix sample action flyout
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 10, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
2940bb2 
* master: (25 commits)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 10, 2020
@gmmorris
Merge branch 'master' into alerts/improve-find-pref
9d86fcd 
* master: (41 commits)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  ...
Dosant added a commit that referenced this pull request Sep 10, 2020
@Dosant
[bugfix] Replace panel flyout opens 2 flyouts (#76931) (#77140)
12a4fe4 
* fix replace panel flyout opens 2 flyouts

* fix sample action flyout
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
e4489fe 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (39 commits)
  [APM] Always load esarchives from common (elastic#77139)
  [Ingest Manager] Handle Legacy ES client errors (elastic#76865)
  [Docs] URL Drilldown (elastic#76529)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  ...

# Conflicts:
#	src/plugins/es_ui_shared/static/forms/hook_form_lib/components/use_array.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] Add panel flyout opens 2 flyouts
4 participants
@Dosant @kibanamachine @streamich @ThomThomson