Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions] - Adds sort order for exception items #76537

Merged
merged 2 commits into from
Sep 2, 2020
Merged

[Security Solution][Exceptions] - Adds sort order for exception items #76537

merged 2 commits into from
Sep 2, 2020

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Sep 2, 2020 •
edited
Loading

Summary

Components affected: ExceptionsViewer

Current behavior:

  • when a user edits an exception item, the order of the exception items in the viewer changes. This creates confusion and looks like updates weren't applied (even though they were, just item order changed)
    no_sort

New behavior:

  • when a user edits an exception item, the order of the exception items in the viewer don't change. Sort order is now based on entries.field
    sort

Checklist

@yctercero yctercero added enhancement New value added to drive a business result Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Detection Rules Security Solution rules and Detection Engine labels Sep 2, 2020
@yctercero yctercero requested review from a team as code owners September 2, 2020 16:32
@yctercero yctercero self-assigned this Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad
FrankHassanabad approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yctercero
Copy link
Contributor Author

@FrankHassanabad thanks for taking a look and following up. I updated the sort_field to add more stability in the sort since as you pointed out, the fields are more likely to change and could result in that same flipping effect we experience now.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
lists 164.3KB +42.0B 164.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit c46e777 into elastic:master Sep 2, 2020
yctercero added a commit to yctercero/kibana that referenced this pull request Sep 2, 2020
@yctercero
[Security Solution][Exceptions] - Adds sort order for exception items (…
de08162 
…elastic#76537)

## Summary

**Components affected:** ExceptionsViewer

**Current behavior:**
  - when a user edits an exception item, the order of the exception items in the viewer changes. This creates confusion and looks like updates weren't applied (even though they were, just item order changed)

**New behavior:**
  - when a user edits an exception item, the order of the exception items in the viewer don't change. Sort order is now based on `created_at`
@yctercero yctercero mentioned this pull request Sep 2, 2020
Merged
yctercero added a commit that referenced this pull request Sep 3, 2020
@yctercero
[Security Solution][Exceptions] - Adds sort order for exception items (…
a34b0a2 
…#76537) (#76567)

## Summary

**Components affected:** ExceptionsViewer

**Current behavior:**
  - when a user edits an exception item, the order of the exception items in the viewer changes. This creates confusion and looks like updates weren't applied (even though they were, just item order changed)

**New behavior:**
  - when a user edits an exception item, the order of the exception items in the viewer don't change. Sort order is now based on `created_at`
@yctercero yctercero deleted the comments_exceptions branch September 3, 2020 14:22
@yctercero yctercero mentioned this pull request Sep 3, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees

@yctercero yctercero

Labels
enhancement New value added to drive a business result Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yctercero @elasticmachine @kibanamachine @FrankHassanabad @MindyRS