Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Use null instead of empty string #76505

Merged
merged 2 commits into from
Sep 4, 2020
Merged

[Monitoring] Use null instead of empty string #76505

merged 2 commits into from
Sep 4, 2020

Conversation

chrisronline
Copy link
Contributor

Follow up from #76257

We expect a non value to be explicitly null for this setting, as per our usage collection code.

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 2, 2020
@chrisronline chrisronline self-assigned this Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

pgayvallet
pgayvallet approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the mistake

@chrisronline
Copy link
Contributor Author

@pgayvallet I totally missed it too :(

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit d44ef9b into elastic:7.x Sep 4, 2020
@chrisronline chrisronline deleted the monitoring/7.x_null branch September 4, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @elasticmachine @kibanamachine @pgayvallet