Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add auto interval to histogram AggConfig (#76001) #76449

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Sep 1, 2020

Backports the following commits to 7.x:

* Add `auto` interval to histogram AggConfig

Closes: elastic#75438

* fix JEST

* update UI

* add tests

* some changes

* small changes

* cleanup code

* fix PR comment

* fix PR comments

* fix PR comment

* Update src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.test.ts

Co-authored-by: Wylie Conlon <[email protected]>

* Change algorithm for auto interval

* Update src/plugins/data/common/search/aggs/buckets/histogram.ts

Co-authored-by: Luke Elmers <[email protected]>

* added some comments

* Update src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.ts

Co-authored-by: Wylie Conlon <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: Luke Elmers <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
charts 269 +1 268
data 546 +1 545
regionMap 252 +1 251
tileMap 258 +1 257
visTypeMarkdown 259 +1 258
visTypeMetric 261 +1 260
visTypeTable 278 +1 277
visTypeTagcloud 262 +1 261
visTypeTimelion 281 +1 280
visTypeVega 312 +1 311
visTypeVislib 508 +1 507
visualize 316 +1 315
total +12

async chunks size

id value diff baseline
visualize 697.6KB +3.9KB 693.8KB

page load bundle size

id value diff baseline
charts 877.5KB +3.9KB 873.6KB
data 1.4MB +3.2KB 1.4MB
regionMap 836.3KB +3.9KB 832.4KB
tileMap 847.9KB +3.9KB 844.1KB
visTypeMarkdown 560.0KB +3.9KB 556.1KB
visTypeMetric 584.7KB +3.9KB 580.9KB
visTypeTable 608.8KB +3.9KB 604.9KB
visTypeTagcloud 841.2KB +3.9KB 837.3KB
visTypeTimelion 716.0KB +3.9KB 712.1KB
visTypeVega 665.5KB +3.9KB 661.7KB
visTypeVislib 1.3MB +3.9KB 1.3MB
total +41.8KB

oss distributable file count

id value diff baseline
total 28997 +1 28996

distributable file count

id value diff baseline
total 47254 +1 47253

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit defb31d into elastic:7.x Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants