Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor NetworkTopNFlow to use Search Strategy #76249

Merged
merged 10 commits into from
Sep 4, 2020
Merged

[Security Solution] Refactor NetworkTopNFlow to use Search Strategy #76249

merged 10 commits into from
Sep 4, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 30, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski patrykkopycinski self-assigned this Aug 30, 2020
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/network-…
4a0cd3d 
…top-f-flow-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/network/index.ts
#	x-pack/plugins/security_solution/public/network/components/network_top_countries_table/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/network_http/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/network_top_countries/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/tls/index.tsx
#	x-pack/plugins/security_solution/public/network/pages/navigation/tls_query_tab_body.tsx
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/query.http_network.dsl.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/tls/query.tls_network.dsl.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_countries/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_countries/query.top_countries_network.dsl.ts
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 4, 2020 11:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

angorayc
angorayc reviewed Sep 4, 2020
View reviewed changes
...curity_solution/server/search_strategy/security_solution/factory/network/top_n_flow/index.ts Outdated
const edges = networkTopNFlowEdges.splice(cursorStart, querySize - cursorStart);
const inspect = {
dsl: [inspectStringifyObject(buildTopNFlowQuery(options))],
response: [inspectStringifyObject(response)],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this and take it from rawResponse.

angorayc
angorayc approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, all looks good, I think we could remove this:
https://github.com/elastic/kibana/pull/76249/files#diff-804f55075441579e4fdf084ec746bc99R43
Good to merge once that's fixed. Thanks you @patrykkopycinski

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1948 +1 1947

async chunks size

id value diff baseline
securitySolution 9.9MB +1.3KB 9.9MB

distributable file count

id value diff baseline
total 45466 +4 45462

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 8a9c486 into elastic:master Sep 4, 2020
@patrykkopycinski patrykkopycinski deleted the feat/network-top-f-flow-search-strategy branch September 4, 2020 16:59
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 4, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 4, 2020
@patrykkopycinski
[Security Solution] Refactor NetworkTopNFlow to use Search Strategy (e…
82e6658 
…lastic#76249)
patrykkopycinski added a commit that referenced this pull request Sep 4, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Refactor NetworkTopNFlow to use Search Strategy (#…
4628064 
…76249) (#76800)

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 4, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
6c99cde 
* master: (47 commits)
  Do not require id & description when creating a logstash pipeline (elastic#76616)
  Remove commented src/core/tsconfig file (elastic#76792)
  Replaced whitelistedHosts with allowedHosts in actions ascii docs (elastic#76731)
  [Dashboard First] Genericize Attribute Service (elastic#76057)
  [ci-metrics] unify distributable file count metrics (elastic#76448)
  [Security Solution][Detections] Handle conflicts on alert status update (elastic#75492)
  [eslint] convert to @typescript-eslint/no-unused-expressions (elastic#76471)
  [DOCS] Add default time range filter to advanced settings (elastic#76414)
  [Security Solution] Refactor NetworkTopNFlow to use Search Strategy (elastic#76249)
  [Dashboard] Update Index Patterns when Child Index Patterns Change (elastic#76356)
  [ML] Add option to Advanced Settings to set default time range filter for AD jobs (elastic#76347)
  Add CSM app to CODEOWNERS (elastic#76793)
  [Security Solution][Exceptions] - Updates exception item find sort field (elastic#76685)
  [Security Solution][Detections][Tech Debt] - Move to using common io-ts types (elastic#75009)
  [Lens] Drag dimension to replace (elastic#75895)
  URI encode the index names we fetch in the fetchIndices lib function. (elastic#76584)
  [Security Solution] Resolver retrieve entity id of documents without field mapped (elastic#76562)
  [Ingest Manager] validate agent route using AJV instead kbn-config-schema (elastic#76546)
  Updated non-dev usages of node-forge (elastic#76699)
  [Ingest Pipelines] Processor forms for processors K-S (elastic#75638)
  ...
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 24, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS