Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions Modal] Switches modal header #76016

Merged
merged 1 commit into from
Aug 26, 2020
Merged

[Security Solution][Exceptions Modal] Switches modal header #76016

merged 1 commit into from
Aug 26, 2020

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Aug 26, 2020 •
edited
Loading

Summary

Updates add and edit exceptions modal header to match the context menu language (exception -> rule exception)

Screen Shot 2020-08-26 at 2 46 10 PM
Screen Shot 2020-08-26 at 2 47 48 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 26, 2020
@dplumlee dplumlee marked this pull request as ready for review August 26, 2020 18:53
@dplumlee dplumlee requested review from a team as code owners August 26, 2020 18:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

yctercero
yctercero approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's quite complex 😜 Thanks for the update - LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 9.5MB +10.0B 9.5MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dplumlee dplumlee merged commit deb71ec into elastic:master Aug 26, 2020
@dplumlee dplumlee deleted the modal-header-title-fix branch August 26, 2020 21:13
@dplumlee dplumlee mentioned this pull request Aug 26, 2020
Merged
dplumlee added a commit to dplumlee/kibana that referenced this pull request Aug 26, 2020
@dplumlee
[Security Solution][Exceptions Modal] Switches modal header (elastic#…
b7b666d 
…76016)
dplumlee added a commit that referenced this pull request Aug 27, 2020
@dplumlee
[Security Solution][Exceptions Modal] Switches modal header (#76016) (#…
0ad490d 
…76036)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @kibanamachine @yctercero @MindyRS