[Security Solution][Exceptions] - Improve UX for missing exception list associated with rule #75898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
commented
Aug 25, 2020
| @@ -107,13 +109,14 @@ export const AddExceptionModal = memo(function AddExceptionModal({ | |||
| }: AddExceptionModalProps) { | |||
| const { http } = useKibana().services; | |||
| const [comment, setComment] = useState(''); | |||
| const { rule: maybeRule } = useRuleAsync(ruleId); | |||
There was a problem hiding this comment.
I'm using this here to pull out the exception list details of the issue exception list. The error itself gives an id but no other info. Thought of reworking useFetchOrCreateRuleExceptionList to pull out the call it makes to the rule, but wanted to minimize changes for backport to 7.9.1.
yctercero
commented
Aug 25, 2020
| }: EditExceptionModalProps) { | ||
| const { http } = useKibana().services; | ||
| const [comment, setComment] = useState(''); | ||
| const { rule: maybeRule } = useRuleAsync(ruleId); |
There was a problem hiding this comment.
We may be able to refactor these modals to have a common parent, since they both repeat a good amount of logic, right now just doubling logic in each file.
yctercero
added
Feature:Detection Rules
FrankHassanabad
approved these changes
Aug 26, 2020
|
|
||
| useEffect((): void => { | ||
| // Yes, it's redundant, unfortunately typescript wasn't picking up | ||
| // that `listToDelete` is checked in canDisplay404Actions |
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Aug 26, 2020
…st associated with rule (elastic#75898) ## Summary **Current behavior:** - **Scenario 1:** User is in the exceptions viewer flow, they select to edit an exception item, but the list the item is associated with has since been deleted (let's say by another user) - a user is able to open modal to edit exception item and on save, an error toaster shows but no information is given to the user to indicate the issue. - **Scenario 2:** User exports rules from space 'X' and imports into space 'Y'. The exception lists associated with their newly imported rules do not exist in space 'Y' - a user goes to add an exception item and gets a modal with an error, unable to add any exceptions. - **Workaround:** current workaround exists only via API - user would need to remove the exception list from their rule via API **New behavior:** - **Scenario 1:** User is still able to oped edit modal, but on save they see an error explaining that the associated exception list does not exist and prompts them to remove the exception list --> now they're able to add exceptions to their rule - **Scenario 2:** User navigates to exceptions after importing their rule, tries to add exception, modal pops up with error informing them that they need to remove association to missing exception list, button prompts them to do so --> now can continue adding exceptions to rule
|
Hi all, I am reverting this PR as it is causing failures on master due to the incompatability with #74920. |
|
Revert: master/8.0: e773f22 Note there is a functional test runner failure in master/7.x we are working through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current behavior:
New behavior:
Scenario 1: User is still able to oped edit modal, but on save they see an error explaining that the associated exception list does not exist and prompts them to remove the exception list --> now they're able to add exceptions to their rule
Scenario 2: User navigates to exceptions after importing their rule, tries to add exception, modal pops up with error informing them that they need to remove association to missing exception list, button prompts them to do so --> now can continue adding exceptions to rule
Checklist