Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] fix performance degradation after lodash@4 upgrade #75850

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[Visualize] fix performance degradation after lodash@4 upgrade #75850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/vis_type_vislib/public/vislib/lib/vis_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class VisConfig {

const visType = visTypes[visConfigArgs.type];
const typeDefaults = visType(visConfigArgs, this.data);
this._values = _.defaultsDeep({}, typeDefaults, DEFAULT_VIS_CONFIG);
this._values = _.defaultsDeep({ ...typeDefaults }, DEFAULT_VIS_CONFIG);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to add a special case to keep style parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @majagrubic, it made sense when we wanted to change it for

this._values = {
... DEFAULT_VIS_CONFIG
...typeDefaults,
style:{
... DEFAULT_VIS_CONFIG.style
...typeDefaults.style,
}
}

but as I found a way to use defaultsDeep without perf degradation (not using 3 params but just two) the lodash function will do the above for free :)

this._values.el = el;
}

Expand Down