Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Migrate discover.html Angular template to React #75784

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
0ac5b98
Convert ES body of discover doc request to use fields API
kertal Aug 19, 2020
fb91a0e
Migrate angular discover.html template to react
kertal Aug 24, 2020
13a1756
Undo es doc fetch change
kertal Aug 25, 2020
d513821
Enable collapsing of sidebar
kertal Aug 25, 2020
f4060f8
Enable filtering of doc table
kertal Aug 25, 2020
007f84b
Fix tests
kertal Aug 25, 2020
e3710a8
Merge remote-tracking branch 'upstream/master' into kertal-2020-08-24…
kertal Aug 27, 2020
244d2cb
Fix missing data-title and data-description
kertal Aug 27, 2020
2855008
Fix missing timeRange leading to an functional test fail
kertal Aug 27, 2020
e1512e0
Fix another test
kertal Aug 27, 2020
7c5b929
Fix sorting of table
kertal Aug 27, 2020
4b24407
Handle refresh
kertal Aug 27, 2020
3be7374
Fix scroll to bottom
kertal Sep 1, 2020
ccdfc75
Fix invalid painless scripted field functional test
kertal Sep 1, 2020
373aedc
Merge remote-tracking branch 'upstream/master' into kertal-2020-08-24…
kertal Sep 3, 2020
129d7c9
Simplify code
kertal Sep 3, 2020
26b70c1
Fix types
kertal Sep 3, 2020
5caba4a
Fix savedSearches test
kertal Sep 4, 2020
0442073
Fix showSaveQuery
kertal Sep 4, 2020
f10997f
Fix type and cleanup
kertal Sep 4, 2020
55ba25e
Merge master/fix conflicts
kertal Sep 4, 2020
ab2a7c1
Undo accidentally commited code
kertal Sep 4, 2020
c0e0f3e
Merge branch 'master' into kertal-2020-08-24-discover-migrate-discove…
elasticmachine Sep 8, 2020
a328c2c
Address review comments part 1
kertal Sep 9, 2020
f244011
Merge branch 'kertal-2020-08-24-discover-migrate-discover-html' of gi…
kertal Sep 9, 2020
a594b3e
Fix types
kertal Sep 10, 2020
128736f
Migrate fixed_scroll directive
kertal Sep 14, 2020
e514a33
Fix closing sidebar
kertal Sep 14, 2020
9b7e381
Fix debounce tests
kertal Sep 14, 2020
9b6dc07
Merge remote-tracking branch 'upstream/master' into kertal-2020-08-24…
kertal Sep 14, 2020
8011988
Merge branch 'master' into kertal-2020-08-24-discover-migrate-discove…
elasticmachine Sep 14, 2020
f2aacc4
Address review comments
kertal Sep 14, 2020
39e1a15
Merge branch 'kertal-2020-08-24-discover-migrate-discover-html' of gi…
kertal Sep 14, 2020
a59fafc
Merge master/fix conflicts
kertal Sep 14, 2020
ee43b9e
Fix i18n
kertal Sep 14, 2020
f7d6b4b
Set aria-expanded of sidebar
kertal Sep 15, 2020
101ff24
Merge master/fix conflicts
kertal Sep 15, 2020
b6a46bd
Address review comments
kertal Sep 16, 2020
e79be95
Further cleanup of SCSS
kertal Sep 16, 2020
31cf12f
improve sidebar toggle
andreadelrio Sep 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 48 additions & 3 deletions src/plugins/discover/public/application/_discover.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
overflow: hidden;
}

.dscAppContainer {
> * {
position: relative;
}
}
discover-app {
flex-grow: 1;
}
Expand All @@ -17,9 +22,12 @@ discover-app {

// SASSTODO: replace the z-index value with a variable
.dscWrapper {
padding-left: $euiSizeXL;
padding-right: $euiSizeS;
padding-left: 21px;
z-index: 1;
@include euiBreakpoint('xs', 's', 'm') {
padding-left: $euiSizeS;
}
}

@include euiPanel('.dscWrapper__content');
Expand Down Expand Up @@ -104,14 +112,51 @@ discover-app {
top: $euiSizeXS;
}

[fixed-scroll] {
.dscTableFixedScroll {
overflow-x: auto;
padding-bottom: 0;

+ .fixed-scroll-scroller {
+ .dscTableFixedScroll__scroller {
position: fixed;
bottom: 0;
overflow-x: auto;
overflow-y: hidden;
}
}

.dscCollapsibleSidebar {
kertal marked this conversation as resolved.
Show resolved Hide resolved
position: relative;
z-index: $euiZLevel1;

.dscCollapsibleSidebar__collapseButton {
position: absolute;
top: 0;
right: -$euiSizeXL + 4;
cursor: pointer;
z-index: -1;
min-height: $euiSizeM;
min-width: $euiSizeM;
padding: $euiSizeXS * .5;
}

&.closed {
width: 0 !important;
border-right-width: 0;
border-left-width: 0;
.dscCollapsibleSidebar__collapseButton {
right: -$euiSizeL + 4;
}
}
}

@include euiBreakpoint('xs', 's', 'm') {
.dscCollapsibleSidebar {
&.closed {
display: none;
}

.dscCollapsibleSidebar__collapseButton {
display: none;
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
@import 'no_results';
@import 'histogram';
@import './collapsible_sidebar/index';

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import _ from 'lodash';
// Debounce service, angularized version of lodash debounce
// borrowed heavily from https://github.com/shahata/angular-debounce

export function DebounceProviderTimeout($timeout) {
export function createDebounceProviderTimeout($timeout) {
return function (func, wait, options) {
let timeout;
let args;
Expand Down Expand Up @@ -66,7 +66,3 @@ export function DebounceProviderTimeout($timeout) {
return debounce;
};
}

export function DebounceProvider(debounce) {
return debounce;
}
Loading