[build] Include full version in staging package prefix, set productio… #7571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const FOLDER_STAGING = `kibana/staging/${VERSION.match(/\d\.\d\.\d/)[0]}-XXXXXXX/repos/${VERSION.match(/\d\./)[0]}x`; |
There was a problem hiding this comment.
👏 I hated this old code more than you know.
|
@jbudz This needs to be rebased |
jbudz
force-pushed
the
publish-staging
branch
2 times, most recently
from
e36f083 to
40672a7
Compare
…n prefix separately
|
LGTM |
|
jenkins, test this |
elastic-jasper
added a commit
that referenced
this pull request
Jul 26, 2016
--------- **Commit 1:** [build] Include full version in staging package prefix, set production prefix separately * Original sha: 9c37542 * Authored by Jonathan Budzenski <[email protected]> on 2016-06-28T21:26:51Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[build] Include full version in staging package prefix, set productio… Former-commit-id: 717589e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the release task here, this includes the full version when publishing packages to staging
This also sets the production prefixes to use their respective constants