Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scripting issues due to improperly encoded kibana payload #7568

Merged
merged 3 commits into from
Jun 28, 2016
Merged

Fixed scripting issues due to improperly encoded kibana payload #7568

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08a6f40
[fix] Fixed scripting issues due to improperly encoded kibana payload.
bevacqua Jun 28, 2016
2cdb0f9
[fix] Switch to attribute-encoding
bevacqua Jun 28, 2016
e33fa40
[fix] Get rid of <meta> in favor of directive-style element.
bevacqua Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/ui/views/chrome.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
- var j = function (o) { return JSON.stringify(o); }
- var appName = 'kibana';
-
var appName = 'kibana';

function encoded (data) {
var scriptend = /\<\s*\/\s*script\s*>/ig;
var concatend = '</" + "script>';
return JSON.stringify(data).replace(scriptend, concatend);
}

block vars

Expand All @@ -12,5 +18,5 @@ html(lang='en')
title Kibana
block head
body(kbn-chrome, id='#{appName}-body')
script window.__KBN__ = !{j(kibanaPayload)};
script window.__KBN__ = !{encoded(kibanaPayload)};
block content