Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DF Analytics list: ensure job messages and jobs load correctly #75676

Merged
merged 2 commits into from
Aug 24, 2020
Merged

[ML] DF Analytics list: ensure job messages and jobs load correctly #75676

merged 2 commits into from
Aug 24, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 21, 2020 •
edited
Loading

Summary

Fixes #75633

Fixes #75653

job-messages

Functional tests for job messages being loaded to be added in a follow up.

Checklist

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 21, 2020 17:14
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added release_note:skip Skip the PR/issue when compiling release notes and removed v7.1.0 labels Aug 21, 2020
@alvarezmelissa87 alvarezmelissa87 changed the title [ML] DF Analytics list: ensure job messages load correctly in expanded row [ML] DF Analytics list: ensure job messages and jobs load correctly Aug 21, 2020
@qn895
Copy link
Member

qn895 commented Aug 21, 2020

Tested both issues and LGTM

peteharverson
peteharverson approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-expanded-row-messages-fix branch from 16667f8 to 21e7b41 Compare August 24, 2020 13:10
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB -435.0B 8.2MB

History

  • 💔 Build #69762 failed 16667f8329134e0bde33c80f7f783b0372f5c890
  • 💔 Build #69751 failed 6c2bfcc6547097e604fab805f89db42e8b9391c7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 33d3f40 into elastic:master Aug 24, 2020
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 24, 2020
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-expanded-row-messages-fix branch August 24, 2020 15:48
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Aug 24, 2020
@alvarezmelissa87
[ML] DF Analytics list: ensure job messages and jobs load correctly (e…
9e61bcf 
…lastic#75676)

* ensure messages load on first open

* ensure analytics management list does not load infinitely
alvarezmelissa87 added a commit that referenced this pull request Aug 24, 2020
@alvarezmelissa87
[ML] DF Analytics list: ensure job messages and jobs load correctly (#…
4186553 
…75676) (#75774)

* ensure messages load on first open

* ensure analytics management list does not load infinitely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@walterra walterra Awaiting requested review from walterra

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
5 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibanamachine @peteharverson