Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy security plugin #75648

Merged
merged 8 commits into from
Sep 17, 2020
Merged

remove legacy security plugin #75648

merged 8 commits into from
Sep 17, 2020

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Aug 21, 2020 •
edited
Loading

Summary

Part of #71927

Remove the last bits of the legacy security plugin

@pgayvallet
Copy link
Contributor Author

ping @elastic/kibana-security. I thought it would be as simple as removing the x-pack/legacy/plugins/security/index.ts file, but apparently there are still some subtle usages of the plugin, but I'm not sure to see where or how.

Could anyone take a look?

@joshdover joshdover mentioned this pull request Aug 23, 2020
Closed
24 tasks
@joshdover joshdover mentioned this pull request Aug 24, 2020
Closed
14 tasks
@pgayvallet
Copy link
Contributor Author

The failures are caused by FTR tools relying on the presence of the (legacy) security plugin for some checks:

kibana/test/common/services/security/test_user.ts

Lines 42 to 44 in f593455

const isEnabled = () => {
return enabledPlugins.includes('security') && !config.get('security.disableTestUser');
};

Need to wait until #41983 is done to wire this check to the new API instead

Associated files:

  • packages/kbn-dev-utils/src/kbn_client/kbn_client_plugins.ts
  • packages/kbn-dev-utils/src/kbn_client/kbn_client_status.ts

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.10.0 labels Aug 25, 2020
@pgayvallet pgayvallet mentioned this pull request Sep 16, 2020
Merged
3 tasks
@pgayvallet pgayvallet marked this pull request as ready for review September 17, 2020 14:09
@pgayvallet pgayvallet requested a review from a team as a code owner September 17, 2020 14:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@azasypkin azasypkin self-requested a review September 17, 2020 14:18
azasypkin
azasypkin reviewed Sep 17, 2020
View reviewed changes
x-pack/index.js
@@ -5,9 +5,8 @@
*/

import { xpackMain } from './legacy/plugins/xpack_main';
import { security } from './legacy/plugins/security';
Copy link
Member

@azasypkin azasypkin Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would you mind removing two remaining x-pack/legacy/plugins/security entries from the CODEOWNERS file too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and... It's gone! 2177028

azasypkin
azasypkin approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

distributable file count

id value diff baseline
default 45907 -1 45908

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 161a74f into elastic:master Sep 17, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Sep 17, 2020
@pgayvallet
remove legacy security plugin (elastic#75648)
02ff051 
* remove legacy security plugin

* remove legacy plugin check

* adapt mocha tests

* update CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
@pgayvallet pgayvallet mentioned this pull request Sep 17, 2020
Merged
pgayvallet added a commit that referenced this pull request Sep 17, 2020
@pgayvallet
remove legacy security plugin (#75648) (#77783)
3c889c9 
* remove legacy security plugin

* remove legacy plugin check

* adapt mocha tests

* update CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgayvallet @elasticmachine @kibanamachine @azasypkin