Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Unset doc title when app unmounts #75539

Merged
merged 2 commits into from
Aug 21, 2020
Merged

[ML] Transforms: Unset doc title when app unmounts #75539

merged 2 commits into from
Aug 21, 2020

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Aug 20, 2020 •
edited
Loading

Summary

Unsets the doc title when the Transforms app unmounts, so that the browser tab title no longer persists as 'Transforms'.

Checklist

Fixes #72644

@peteharverson peteharverson requested a review from a team as a code owner August 20, 2020 10:52
@peteharverson peteharverson self-assigned this Aug 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
transform 704.5KB +90.0B 704.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@peteharverson peteharverson merged commit 659890c into elastic:master Aug 21, 2020
@peteharverson peteharverson mentioned this pull request Aug 21, 2020
Merged
peteharverson added a commit that referenced this pull request Aug 21, 2020
@peteharverson @elasticmachine
[ML] Transforms: Unset doc title when app unmounts (#75539) (#75627)
ea63cc6 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2020
@peteharverson @elasticmachine @thomasneirynck
[ML] Transforms: Unset doc title when app unmounts (elastic#75539)
0f456f1 
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@peteharverson peteharverson

Labels
Feature:Transforms ML transforms :ml release_note:fix v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Transforms doesn't unset its doc title
5 participants
@peteharverson @elasticmachine @kibanamachine @walterra @alvarezmelissa87