Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Move es-utils to common #75508

Merged
merged 2 commits into from
Aug 20, 2020
Merged

[Maps] Move es-utils to common #75508

merged 2 commits into from
Aug 20, 2020

Conversation

thomasneirynck
Copy link
Contributor

Summary

This PR is a no-op but a pre-requisite for #74319.

It moves es-utils, to common, so it can be reused on the server for mvt tile generation.

Checklist

NA

For maintainers

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 19, 2020
@thomasneirynck thomasneirynck requested a review from a team as a code owner August 19, 2020 22:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB -12.0B 3.3MB

page load bundle size

id value diff baseline
maps 296.2KB -195.0B 296.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese
nreese approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@thomasneirynck thomasneirynck merged commit 954b5b5 into elastic:master Aug 20, 2020
@thomasneirynck thomasneirynck mentioned this pull request Aug 20, 2020
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 20, 2020
@thomasneirynck
[Maps] Move elasticsearch_geo_utils to common (elastic#75508)
fe19faf
thomasneirynck added a commit that referenced this pull request Aug 20, 2020
@thomasneirynck
[Maps] Move elasticsearch_geo_utils to common (#75508) (#75554)
83dbb82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese