Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Fixes exception viewer overflow bug #75489

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Aug 19, 2020

Summary

Fixes exceptions viewer overflow bug by vertically displaying the badges and hiding overflow. Full paths can be seen by hovering over badges or opening the edit exceptions modal

Before
image

After
Screen Shot 2020-08-19 at 2 06 03 PM
Screen Shot 2020-08-19 at 2 09 09 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.10.0 v8.0.0 labels Aug 19, 2020
@dplumlee dplumlee force-pushed the viewer-overflow-bug branch from fa8d47b to c347f99 Compare August 19, 2020 20:05
@dplumlee dplumlee marked this pull request as ready for review August 19, 2020 22:37
@dplumlee dplumlee requested review from a team as code owners August 19, 2020 22:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!! Super nit and not required, but may be useful to add a screenshot of the "before" for reference. LGTM!

Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dplumlee dplumlee merged commit afd90b0 into elastic:master Aug 20, 2020
@dplumlee dplumlee deleted the viewer-overflow-bug branch August 20, 2020 16:00
dplumlee added a commit to dplumlee/kibana that referenced this pull request Aug 20, 2020
dplumlee added a commit that referenced this pull request Aug 20, 2020
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2020
@peluja1012 peluja1012 changed the title [Security Solution][Detections] Fixes viewer overflow bug [Security Solution][Detections] Fixes exception viewer overflow bug Aug 21, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.2MB +6.0B 7.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants