[7364]: Deconcatenate selectors in src/ui/public #7547
Conversation
cjcenizal
force-pushed
the
7364/chore/deconcatenate-selectors-public-styles
branch
from
6391885 to
99464df
Compare
| &-title { | ||
| } | ||
|
|
||
| .kibana-nav-info-title { |
There was a problem hiding this comment.
I'm using the indentation to indicate a parent-child relationship with whitespace, without incurring the additional specificity of nesting. What do you think of this tactic? I've been on teams which have used it successfully in the past... it's a lot easier when the CSS has fewer nested selectors to begin with. :)
There was a problem hiding this comment.
I think it's a needless symptom of tight coupling
|
LGTM besides a couple of minor comments. The table thing is just asking to feel super paintful. Even if we had a nested table inside a table, which I don't think will ever happen in Kibana because this isn't 1995, a highly specific selector like that is super painful when you need to reset a rule. |
|
@bevacqua I absolutely agree with you about the crazy-high specificity. They're landmines! Here's another example: https://github.com/elastic/kibana/blob/master/src/ui/public/styles/theme.less#L46 The problem with untangling these is that it's really difficult to track down where the selectors are applied in our markup. So each one of these situations will need to be tackled in its own branch, and will probably take at least a few hours to a day to work through. |
…te-selectors-public-styles [7364]: Deconcatenate selectors in src/ui/public Former-commit-id: 1248b2f
Relates to #7364