[Logs UI] View log details for anomaly log examples #75425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the user clicked a filter in the `LogEntryFlyout` two callbacks where fired: `setFilter` and `setTarget`. The purpose of the first was to add a filter based on the field where the user clicked. The second was to center the log stream in the line item that corresponded to the item shown in the flyout. Having these two callbacks gave too much knowledge to the `LogEntryFlyout` about what its consumer was doing. It also required the consumer to handle separatedly two events that happened at the same time. This commit removes `setTarget` and modifies `setFilter` to take as arguments the flyoutItemId and its timeKey. Consumers now only need to handle one callback instead of two. In the context of elastic#68433, it also enable the log analysis UI to link to the log stream with both a filter and a position, without needing to build the link from the result of calling the two callbacks.
afgomez
added
v8.0.0
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
Kerry350
reviewed
Aug 25, 2020
x-pack/plugins/infra/public/components/logging/log_entry_flyout/log_entry_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/components/logging/log_entry_flyout/log_entry_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/pages/logs/log_entry_rate/page_results_content.tsx
Show resolved
Hide resolved
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
afgomez
pushed a commit
that referenced
this pull request
Aug 27, 2020
…75954) Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #68443.
Add a "View detail" link to the log line examples that opens a
LogEntryFlyout.The interface for
LogEntryFlyoutwas simplified a bit. We were using two callbacks when the user clicked in the filter icons, each one being responsible to set a different bit of state. I simplified it to only one callback to make it easy to link to the log stream from outside.