Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting/Fn Test] Re-enable listing of reports tests #75383

Merged
merged 9 commits into from
Aug 21, 2020
Merged

[Reporting/Fn Test] Re-enable listing of reports tests #75383

merged 9 commits into from
Aug 21, 2020

Conversation

tsullivan
Copy link
Member

Summary

Fixing a flaky test that was skipped.

Closes #75044

@tsullivan tsullivan mentioned this pull request Aug 18, 2020
Closed
@tsullivan tsullivan marked this pull request as ready for review August 19, 2020 01:34
@tsullivan tsullivan requested a review from joelgriffith August 19, 2020 01:34
@tsullivan tsullivan added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 19, 2020
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan mentioned this pull request Aug 19, 2020
Merged
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

tsullivan commented Aug 20, 2020 •
edited
Loading

Failed due to unrelated test CI downtime:

               └- ✖ fail: detection engine api security and spaces enabled delete_rules_bulk deleting rules bulk using DELETE should delete a single rule using an auto generated id
               │      Error: ECONNREFUSED: Connection refused

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

tsullivan
tsullivan commented Aug 21, 2020
View reviewed changes
x-pack/test/functional/apps/reporting_management/report_listing.ts
expect(await previousButton.getAttribute('disabled')).to.be('true');

// scan page 1
let tableText = await getTableTextFromElement(await testSubjects.find('reportJobListing'));
const PAGE_CONTENT_1 = `[Logs] File Type Scatter Plot\nvisualization\n2020-04-21 @ 07:01 PM\ntest_user\nCompleted at 2020-04-21 @ 07:02 PM
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I could tell, the check against all the text in the table was not always matching after the page had switched. But we should be able to check that the first row is the one we expect per each page.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

I'm going to self-merge this, because it just simplifies code that's already been reviewed, and unskips a test

@tsullivan tsullivan merged commit e0cea77 into elastic:master Aug 21, 2020
@tsullivan tsullivan deleted the reporting/fn-testing-job-listing-iii branch August 21, 2020 20:21
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 25, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75383 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75383 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75383 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75383 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75383 or prevent reminders by adding the backport:skip label.

@tsullivan
Copy link
Member Author

backported in #75500

@tsullivan tsullivan added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelgriffith joelgriffith Awaiting requested review from joelgriffith

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@tsullivan @kibanamachine @elasticmachine