[SIEM] Fixes 'sets and reads the url state for timeline by id' timeline Cypress test #75125
Conversation
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
MadameSheema
requested review from
XavierM,
patrykkopycinski,
stephmilovic and
angorayc
MadameSheema
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
When I focused
Cypress captured the following screenshot when the test failed:
|
There was a problem hiding this comment.
Thanks for updating this test @MadameSheema!
Tested locally by focusing url_state.spec.ts and running node x-pack/plugins/security_solution/scripts/loop_cypress_tests.js 10 to test for flakes
LGTM 🚀
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
…ne Cypress test (elastic#75125) * fixes 'sets and reads the url state for timeline by id' timeline ttest * makes test more reliable Co-authored-by: Elastic Machine <[email protected]>
…ne Cypress test (#75125) (#75745) * fixes 'sets and reads the url state for timeline by id' timeline ttest * makes test more reliable Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
In this PR we are fixing the 'sets and reads the url state for timeline by id' timeline Cypress test.
Before we were getting the timeline id from the url before creating it. That was not completely reliable and made also the test slow. Now we are getting the timeline id from the API call, making the test faster and reliable.