Uppercase -SNAPSHOT on snapshot builds #7477
Merged
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do snapshot urls in the readme need to be updated too? |
|
Yep, good catch. |
This is consistent with other Elastic projects.
|
@jbudz Better? |
|
LGTM |
epixa
added a commit
that referenced
this pull request
Jul 22, 2016
--------- **Commit 1:** Uppercase -SNAPSHOT on snapshot builds This is consistent with other Elastic projects. * Original sha: 7eaa191 * Authored by Court Ewing <[email protected]> on 2016-06-15T20:36:12Z
epixa
added a commit
that referenced
this pull request
Jul 22, 2016
[backport] PR #7477 to 4.x - Uppercase -SNAPSHOT on snapshot builds
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Uppercase -SNAPSHOT on snapshot builds Former-commit-id: 6b98215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with other Elastic projects.
I probably didn't need to update all of the tests, but I didn't want to make any assumptions.