Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server/status] implement generic status tracking #7459

Merged
merged 7 commits into from
Jun 15, 2016
Merged

[server/status] implement generic status tracking #7459

merged 7 commits into from
Jun 15, 2016

Commits on Jun 15, 2016

  1. [server/status] implement generic status tracking 

    In elastic#7333 we needed the ability to set the server status from outside of a plugin, but statuses were implemented in a way that coupled them to plugins. This let to reaching in and setting the status of a plugin from the server. Rather than extending the undesirable coupling of status & plugin I've instead made the server status service support creating more generic status tracker objects, and extended it's API to include plugin-specific methods like `createForPluginId(pluginId)` and `getStateForPluginId(pluginId)`.

With the new API the settings service will be able to create it's own status object with `kbnServer.status.create('settings')` rather than reaching into the kibana plugin and setting its status.
    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    e6a8da0 View commit details
    Browse the repository at this point in the history

  2. [status] update functional tests to use testSubject selector

    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    ef9eba5 View commit details
    Browse the repository at this point in the history

  3. [server/status] cleanup services table on status page

    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    fe67508 View commit details
    Browse the repository at this point in the history

  4. [statusPage] remove "service" naming

    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    8cb1694 View commit details
    Browse the repository at this point in the history

  5. [statusPage] remove status grouping, fix some classnames

    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    10be384 View commit details
    Browse the repository at this point in the history

  6. [server/status] remove PluginStatus class

    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    1504a9e View commit details
    Browse the repository at this point in the history

  7. [statusPage] update functional test

    spalger committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    e232e07 View commit details
    Browse the repository at this point in the history