Improve performance in the table. Re #719 and #732 #745
+289
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
pushed a commit
to w33ble/kibana
that referenced
this pull request
Sep 13, 2018
* Added shape function * Added color arg type * Added shape render function * Added shapes * Added shape components and shape arg type * Cleaned up shapes * Added stroke-miterlimit to prevent corners from beveling * Removed unused prop and id from shape_picker_mini * Added default values to color, number, shape, and toggle. Generated id in popover * Updated default shape element expression * Fixed falsy check for borderWidth to allow 0. Changed default color arg value to black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance in the table significantly, especially when dealing with large numbers of fields.
Testing shows these changes contribute to a 3-5x performance improvement when dealing with a dataset containing 2000 different fields. Probably still better to have fewer fields.