Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Enterprise Search] Fix/DRY out plugin i18n strings (#74323) #74425

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Aug 5, 2020

Backports the following commits to 7.x:

* i18n refactor

- DRY out plugin details to constants and correctly i18n-ize front-end-facing strings

* DRY out new i18n constants

- refactor instances of i18n.translate to use new constants

* Fix non-i18n'd breadcrumb strings

* PR feedback: swap out more plugin ID strings for constants
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
enterpriseSearch 264.9KB -206.0B 265.1KB

page load bundle size

id value diff baseline
enterpriseSearch 19.3KB +1.7KB 17.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit fb43180 into elastic:7.x Aug 6, 2020
@cee-chen cee-chen deleted the backport/7.x/pr-74323 branch August 6, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants