Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deb/rpm] remove sysv #74424

Merged
merged 20 commits into from
Oct 29, 2020
Merged

[deb/rpm] remove sysv #74424

merged 20 commits into from
Oct 29, 2020

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Aug 5, 2020 •
edited
Loading

Modestly simplify our builds - this is part of a consistency match with elasticsearch. We'll get some bonus fixes e.g. sysv and sys/v will not have log destination differences and avoid the confusion including both in the build (which was a bug - we should have installed one based on capabilities)

8.0 only

Release note:

Removes support for SysV init. Systems that don't have service aliased to use kibana.service should use systemctl start kibana.service instead of the service start kibana.

@jbudz jbudz added release_note:breaking Team:Operations Team label for Operations Team v8.0.0 labels Aug 5, 2020
@jbudz jbudz requested a review from a team as a code owner August 5, 2020 20:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger changed the title [build remove sysv [build] remove sysv Aug 5, 2020
@jbudz
Copy link
Member Author

jbudz commented Aug 10, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Aug 13, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

Can you also remove sysv from the docs?

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

tylersmalley
tylersmalley suggested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove from the docs and update the PR description to include the release note per https://www.elastic.co/guide/en/kibana/current/contributing.html#kibana-release-notes-process

@jbudz
Copy link
Member Author

jbudz commented Sep 21, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

Please ping me when feedback has been addressed.

@jbudz jbudz changed the title [build] remove sysv [deb/rpm] remove sysv Oct 27, 2020
@jbudz
Copy link
Member Author

jbudz commented Oct 27, 2020 •
edited
Loading

Updated docs, added release note, good to go.
Testing

  • /etc/init.d/kibana should not exist
    - /etc/default/kibana should exist
  • There should be no references to sysv in documentation.
  • /etc/init.d/kibana status should error
  • systemctl start kibana.service should start kibana normally.

Most distros have service aliased to systemctl, but if not it would try sysv and should also cause a failure.

https://kibana_74424.docs-preview.app.elstc.co/diff
https://s3-us-west-1.amazonaws.com/kibana.budzenski.com/74424/3aa7eb7/kibana-8.0.0-SNAPSHOT-amd64.deb
https://s3-us-west-1.amazonaws.com/kibana.budzenski.com/74424/3aa7eb7/kibana-8.0.0-SNAPSHOT-x86_64.rpm

@jbudz
Copy link
Member Author

jbudz commented Oct 27, 2020

@elasticmachine merge upstream

tylersmalley
tylersmalley reviewed Oct 28, 2020
View reviewed changes
docs/setup/install/rpm.asciidoc Outdated

[[rpm-running-init]]
include::rpm-init.asciidoc[]
==== `systemd`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should actually remove this line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a little odd and the next header covers it:

image

tylersmalley
tylersmalley reviewed Oct 28, 2020
View reviewed changes
docs/setup/install/deb.asciidoc Outdated

[[deb-running-init]]
include::deb-init.asciidoc[]
==== `systemd`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback as https://github.com/elastic/kibana/pull/74424/files#r513806872

tylersmalley
tylersmalley approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@jbudz
Copy link
Member Author

jbudz commented Oct 29, 2020

New docs with the title removed: https://kibana_74424.docs-preview.app.elstc.co/guide/en/kibana/master/deb.html.

We discussed on slack, will be merging on green

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 3ee6656 into elastic:master Oct 29, 2020
@jbudz jbudz deleted the rm/sysv branch October 29, 2020 15:37
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 74424 or prevent reminders by adding the backport:skip label.

@jbudz jbudz added the backport:skip This commit does not require backporting label Nov 2, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:breaking release_note:deprecation Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbudz @elasticmachine @tylersmalley @kibanamachine