[Resolver] node list and node detail tests #74421

oatkiller · 2020-08-05T20:08:31Z

Summary

Change the way the resolver simulator works
refactor resolver tree and data access layer mocks
Fix bug where timestamp and pid sometimes don't show in the node detail view
add a few tests for the panel (not done, but worth committing.)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

oatkiller · 2020-08-06T15:57:09Z

x-pack/plugins/security_solution/public/resolver/test_utilities/simulator/index.tsx

-     *
-     * NB: the logic to short-circuit the loop is here because knowledge of state is a concern of the simulator, not tests.
-     */
+  public async *map<R>(mapper: () => R): AsyncIterable<R> {


this replaces mapStateTransitions

oatkiller · 2020-08-06T15:57:38Z

x-pack/plugins/security_solution/public/resolver/test_utilities/simulator/index.tsx

+      const title = titles.at(index).text();
+      const description = descriptions.at(index).text();
+
+      // Exclude timestamp since we can't currently calculate the expected description for it from tests


the timestamp is wrong anyway

oatkiller · 2020-08-06T15:58:31Z

x-pack/plugins/security_solution/public/resolver/view/clickthrough.test.tsx

@@ -82,27 +84,24 @@ describe('Resolver, when analyzing a tree that has 1 ancestor and 2 children', (
          .first()
          .simulate('click');
      });
-      it('should render the second child node as selected, and the first child not as not selected, and the query string should indicate that the second child is selected', async () => {
+      it('should render the second child node as selected, and the origin as not selected, and the query string should indicate that the second child is selected', async () => {


wording was wrong, test was right.

oatkiller · 2020-08-06T15:59:18Z

x-pack/plugins/security_solution/public/resolver/view/panels/panel_content_process_detail.tsx

    const eventTime = event.eventTimestamp(processEvent);
-    const dateTime = eventTime ? formatDate(eventTime) : '';
+    const dateTime = eventTime === undefined ? null : formatDate(eventTime);


Show the timestamp even if it's the unix epoch

oatkiller · 2020-08-06T15:59:33Z

x-pack/plugins/security_solution/public/resolver/view/panels/panel_content_process_detail.tsx

@@ -107,7 +108,7 @@ export const ProcessDetails = memo(function ProcessDetails({
      commandLineEntry,
    ]
      .filter((entry) => {
-        return entry.description;
+        return entry.description !== undefined;


show the pid and timestamp if they are present

oatkiller · 2020-08-06T16:04:16Z

...ugins/security_solution/public/resolver/data_access_layer/mocks/one_ancestor_two_children.ts

@@ -43,24 +40,11 @@ interface Metadata {
 /**
 * A simple mock dataAccessLayer possible that returns a tree with 0 ancestors and 2 direct children. 1 related event is returned. The parameter to `entities` is ignored.
 */
-export function oneAncestorTwoChildren(
-  { withRelatedEvents }: { withRelatedEvents: Iterable<[string, string]> | null } = {


Removed options from this function, split that behavior off into its own function.

bkimmel · 2020-08-06T17:48:24Z

x-pack/plugins/security_solution/public/resolver/mocks/resolver_tree.ts

+    secondChildID,
+  });
+  const withRelatedEvents: Array<[string, string]> = [
+    ['registry', 'access'],


❔ I was hoping to make this a little more reusable, e.g. being able to pass in the set of related events from the test,

i was hoping for the opposite :) let's discuss in office hours?

we followed up. README with recommendations for writing mocks will be added next PR

kibanamachine · 2020-08-06T22:48:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2f29ae1

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+192.0B	7.3MB

History

💚 Build #66974 succeeded dd31829da5b7da77c087cf767ed4964f55a82a48
💔 Build #66942 failed 69115889e1fb09d9628042cec0d259d3060189ab
💛 Build #66922 was flaky 07f66a77bafa43466dc6176895fd79edb57a225f
💔 Build #66964 failed 19e6c7458d2bc69014f14779ba43a8fb2bc8416f
💚 Build #66767 succeeded 72678c722ce711cc8eb42362209b55d217c39c9a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Change the way the resolver simulator works * refactor resolver tree and data access layer mocks * Fix bug where timestamp and pid sometimes don't show in the node detail view * add a few tests for the panel (not done, but worth committing.)

kibanamachine · 2020-08-11T13:18:45Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

* Change the way the resolver simulator works * refactor resolver tree and data access layer mocks * Fix bug where timestamp and pid sometimes don't show in the node detail view * add a few tests for the panel (not done, but worth committing.) Co-authored-by: Elastic Machine <[email protected]>

oatkiller · 2020-08-20T18:48:25Z

x-pack/plugins/security_solution/public/resolver/view/panels/process_details.tsx

    const eventTime = event.eventTimestamp(processEvent);
-    const dateTime = eventTime ? formatDate(eventTime) : '';
+    const dateTime = eventTime === undefined ? null : formatDate(eventTime);


By checking if the value is undefined we can support showing the date even if it is the unix epoch (00:00:00 UTC on 1 January 1970.)

oatkiller · 2020-08-20T18:49:40Z

x-pack/plugins/security_solution/public/resolver/view/panels/process_details.tsx

@@ -107,7 +108,7 @@ export const ProcessDetails = memo(function ProcessDetails({
      commandLineEntry,
    ]
      .filter((entry) => {
-        return entry.description;
+        return entry.description !== undefined;


By checking for undefined here we will show the PID of a process if it is 0

oatkiller requested a review from bkimmel August 5, 2020 20:08

oatkiller force-pushed the test-panel branch from 07f66a7 to 6911588 Compare August 6, 2020 15:16

oatkiller commented Aug 6, 2020

View reviewed changes

oatkiller marked this pull request as ready for review August 6, 2020 16:00

oatkiller requested review from a team as code owners August 6, 2020 16:00

oatkiller added release_note:fix v7.10.0 labels Aug 6, 2020

oatkiller changed the title ~~Test panel~~ [Resolver] node list and node detail tests Aug 6, 2020

oatkiller commented Aug 6, 2020

View reviewed changes

bkimmel reviewed Aug 6, 2020

View reviewed changes

did it

2f29ae1

oatkiller force-pushed the test-panel branch from dd31829 to 2f29ae1 Compare August 6, 2020 20:55

oatkiller mentioned this pull request Aug 6, 2020

[Resolver] Improve simulator. Add more click-through tests and panel tests. #74601

Merged

13 tasks

bkimmel approved these changes Aug 7, 2020

View reviewed changes

oatkiller merged commit 7dc33f9 into elastic:master Aug 7, 2020

oatkiller deleted the test-panel branch August 7, 2020 13:15

oatkiller mentioned this pull request Aug 7, 2020

[7.x] [Resolver] UI tests for the panel and bug fix (#74421) #74616

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 11, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 11, 2020

oatkiller commented Aug 20, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Resolver] node list and node detail tests #74421

[Resolver] node list and node detail tests #74421

oatkiller commented Aug 5, 2020 •

edited

Loading

oatkiller Aug 6, 2020

oatkiller Aug 6, 2020

oatkiller Aug 6, 2020

oatkiller Aug 6, 2020

oatkiller Aug 6, 2020

oatkiller Aug 6, 2020

bkimmel Aug 6, 2020 •

edited

Loading

oatkiller Aug 6, 2020

oatkiller Aug 6, 2020

kibanamachine commented Aug 6, 2020

kibanamachine commented Aug 11, 2020

oatkiller Aug 20, 2020

oatkiller Aug 20, 2020

[Resolver] node list and node detail tests #74421

[Resolver] node list and node detail tests #74421

Conversation

oatkiller commented Aug 5, 2020 • edited Loading

Summary

Checklist

For maintainers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkimmel Aug 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Aug 6, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

kibanamachine commented Aug 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller commented Aug 5, 2020 •

edited

Loading

bkimmel Aug 6, 2020 •

edited

Loading