[Canvas][tech-debt] Renderer stories #74373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
force-pushed
the
renderer-stories
branch
from
b61563f to
b3b2131
Compare
poffdeluxe
approved these changes
Aug 18, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Sep 1, 2020
* Add stories for renderers * Fix Typecheck Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Add stories for renderers * Fix Typecheck Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Storybook Stories for all of our renderers.
The captures snapshots are captured properly due to #74370
This builds on previous PR #74134 so only the last commit here are the changes that differ from that